HENRY Florian

Results 46 comments of HENRY Florian

@s-aga-r Could have a look ?

@s-aga-r @rohitwaghchaure just another dummy comment to remove "Inactive" label. Hope you can find time to review this one and the other "fix semgrep" related PR #41309

@s-aga-r @rohitwaghchaure just another dummy comment again to remove "Inactive" label. Hope you can find time to review this one and the other "fix semgrep" related PR https://github.com/frappe/erpnext/pull/41309 Also, could...

Note to reviewer : I added tests after first commit, so label need-test is not accurate

@deepeshgarg007 No reviewer auto-assign on this PR ? Could you have a look please ?

@deepeshgarg007 No reviewer auto-assign on this PR ? Could you have a look please ?

Hello Frappe Team, there are no "auto-reviewer" for this PR affected by default. Could you guide us to the best process, as this PR already respect the Contributing Guideline, to...

@barredterra, @s-aga-r Sorry to bother you both with this, but on theses two PRs #41308 and this one (they are linked), I didn't get any feedback from Frappe Team since...

Do you suggest to add another section/tab in System Setting (and why not by user setting) with Field CSV Delimiter: Drop down with `,` `;` `\t` `|` CSV Quoting :...

> Configuring and exporting CSVs should "feel" the same everywhere in the system. If we introduce a new way, it will get more confusing. Better repurpose what's already there, or...