node-request-retry
node-request-retry copied to clipboard
How to listen to finish of a write stream if requests were retried?
I have:
return new Promise<string>(resolve => {
request(options)
.pipe(fs.createWriteStream(fileName))
.on("finish", function () {
console.log("The file should be completely written here");
resolve(fileName);
});
});
and I expected the finish
to only be emitted if one of my retryable requests went through.
Instead, if there is a retry, the finish
will be emitted already for the first request and resolve the promise prematurely.
I want to resolve my Promise if and only if one request was successful and the writing to the stream finished with the content. How do I achieve that?
Hello @k0pernikus,
Indeed that would be a new feature, requestretry is more oriented towards requests retry that stream retry, so that why you don't have the intended behaviour.
I will happily accept a PR with tests for this :)
Hey, is there any update on this issue ? @k0pernikus @FGRibreau
I need to do pipe request body to a file only when we get some file in our response body.
How to achieve that ? Is there any solution with request retry ? @FGRibreau
@k0pernikus @rishav-csenitjsr
How to achieve that ? Is there any solution with request retry ?
I don't think so, I'm open for PR along with tests that fixes that :+1: