Filipe Laíns 🇵🇸

Results 478 comments of Filipe Laíns 🇵🇸

CompatibilityFiles would use this. We could add a dispatch for that too, but that's 2 different cases now and `os.PathLike` would be able to handle both.

`CompatibilityFiles` is an abstraction over `ResourceReader`, it implements a `Traversable` interface using `ResourceReader.contents`, `ResourceReader.resource_path`, etc. In this case, the resource file can exist on the filesystem, but we cannot simply...

> Something indeed seems off in the package when run under powershell. On my machine, any error when running `pkg-config.exe` will enter a endless loop printing out error messages. Something...

@mattip can you try again with `pkgconf==2.1.1-8`? I added some logs to help understand what's going on. It is expected `pkgconf` to be called multiple times, we run the system...

Does `python -m pkgconf` behave any differently?

I identified some issues on older Python versions, which could have lead to our `pkgconf`/`pkg-config` failing. I fixed them and added CI for all supported Python versions. I'll release it...

I tried to reproduce locally in powershell and I can't seem to get meson to fail to correctly find `pkg-config`.

Here are my steps to try to reproduce in a Windows 10 machine with Python 3.10 installed: ``` $ powershell $ git clone https://github.com/numpy/numpy $ cd numpy $ git submodule...

Perhaps this is due to pip's build isolation, and meson-python's sdist being derived from `meson dist`. Can you try to run the pip command with `--no-build-isolation`? I think that's what...