Travis deployment to docker_hub

[petr-tik]

add an on_success scenario to travis and save dockerhub credentials.

@jbcoe do you want to create and move ffig to a separate repo on the dockerhub? It's better for your security. In case travis ever gets cracked for credentials, at least your personal github won't be compromised.

[jbcoe]

Not sure I follow. Can you elaborate?

What would it take to do? If I understand the risks and work I'm happy to do it.

[petr-tik]

For the ffi-explorer web app, it would be good to agree on a base docker image we can reuse and docker pull that from a repo.

Right now, we push the new docker image to a docker repo connected to your account. if you are ok with giving travis your docker credentials , then I will be pulling from the jbcoe docker repo

[jbcoe]

Why does travis need my docker credentials?

[petr-tik]

to docker push on success

https://docs.travis-ci.com/user/docker/#Pushing-a-Docker-Image-to-a-Registry

[jbcoe]

Can we get docker to only pull from GitHub on successful builds? That would not require credentials.

[petr-tik]

I am thinking about about tagging the build as latest. If it passes the tests, docker push it to the repo. Whenever the ffig-app is built, it will pull the image with the latest tag.

Pulling doesn't require credentials, pushing does, but it looks like we are already doing it. Just wanted to confirm that it's ok with you

[ajbennieston]

I mentioned this on slack yesterday but: maybe it's time to make ffig GitHub organisation? That way none of the things are tied to Jon's personal GitHub. If ffig tokens / credentials are leaked, any potential damage is limited.

Having said that, would still like to understand which things truly need those and which can be worked around without providing write access.

[jbcoe]

I don't think anything much has write access right now.

[jbcoe]

I've created an organisational repo at https://github.com/ffig

I'll migrate stuff over tonight. Please don't create new PRs or branches in the meantime.

[petr-tik]

https://help.github.com/articles/transferring-a-repository-owned-by-your-personal-account/#transferring-a-repository-to-another-user-account-or-to-an-organization

[jbcoe]

@petr-tik thanks. That will get me my evening back.

[jbcoe]

migration complete. We are https://github.com/FFIG on github and c-api on slack.