dolfinx icon indicating copy to clipboard operation
dolfinx copied to clipboard

Add Real Space

Open jhale opened this issue 2 years ago • 9 comments

Builds on previous work of @mscroggs.

Currently brings in tensor related branches from @garth-wells so would need to wait before merging.

jhale avatar Jul 11 '22 09:07 jhale

What is the parallel ownership of real element dofs?

For performance reasons we could pack coefficients of Real element in a similar way to how Constants are packed - outside of the main assembly loop, just once per domain. Legacy approach to Real element has many bottlenecks, I thought we opted for redesign.

michalhabera avatar Jul 11 '22 14:07 michalhabera

I have some old Dolfin-based code that makes use of real spaces that I am trying to port to DolfinX. I was wondering if the capability in this branch is likely to be merged with the main branch in the near future or if I am better off using this branch directly? Thanks!

tbrandvik avatar Jul 25 '22 23:07 tbrandvik

Perhaps not @tbrandvik, because I agree with @michalhabera that there are better ways of doing this. I have a research problem that required this implementation and I had to get it done quickly (it worked for my purposes).

I would add that this branch does not currently work in parallel, and the inner product of a real function and a finite element function in a form is also not giving the right output. So be careful!

jhale avatar Jul 27 '22 14:07 jhale

Thanks @jhale - that is useful information. Hopefully support for real spaces become part of the main branch at some point!

tbrandvik avatar Jul 27 '22 20:07 tbrandvik

Hi,

As I understand real space is still not available within DolfinX? or Is there a way to use it.

GSadashivaiah27 avatar Aug 09 '22 21:08 GSadashivaiah27

I'm also interested in this feature. BTW Are there plans when the tensor related branches by @garth-wells will be merged?

twmr avatar Oct 03 '22 20:10 twmr

I'm also interested in this feature. Do you think it will be incorporated?

ramrebol avatar Oct 11 '22 00:10 ramrebol

It will be added at some point (hopefully soon). I still needs some careful thought on how to do it while maintaining decent performance.

garth-wells avatar Oct 11 '22 09:10 garth-wells

thanks @garth-wells for answer. May you suggest me a better way to impose the integral of the pressure equal to zero in a Stokes problem? (Typical stationary Stokes problem with Dirichlet boundary condition only).

ramrebol avatar Oct 11 '22 13:10 ramrebol

Any status updates on this issue? I have an application in which I would like to use real type spaces.

jkrokowski avatar Nov 28 '22 19:11 jkrokowski

We need to come back to this with a focused effort. Closing for now.

garth-wells avatar Nov 08 '23 08:11 garth-wells