angular-google-charts icon indicating copy to clipboard operation
angular-google-charts copied to clipboard

Angular 15

Open oobayly opened this issue 2 years ago • 12 comments

When I created #278 I [stupidly] targeted Angular 14, which has meant that the package can't be used with Angular 13 - something that's just bitten me in the a**. Also noted in #282

This PR reverts the build version to Angular 12 (v.2.2.2), but updates the peer dependencies to <=15.x (#292)

~Initially, I want to check that this builds correctly on CircleCI~ CircleCI passes now, and I appreciate that releasing a package version that targets a lower Angular version may be problematic.

My next task is to try using this in an angular app starting with 12 to make sure I haven't screwed anything up.

  • [x] Install, and run on Angular 12
  • [x] Install, and run on Angular 13
  • [x] Install, and run on Angular 14
  • [x] Install, and run on Angular 15
  • [x] Install on Angular 12, and upgrade incrementally to Angular 15

I've also included the following:

  • @kussmaul fix in #277
  • #297

oobayly avatar Feb 22 '23 18:02 oobayly

Bumping this thread. Is there any momentum to have this pull request reviewed and merged.

CarnsJalone avatar Mar 02 '23 15:03 CarnsJalone

We could really use this PR merged for our team. It is preventing us from completing our update to Angular 15 since we use this package.

mlangwell avatar Mar 06 '23 13:03 mlangwell

same here, this is the last package preventing us from updating to Angular 15

lazybobcat avatar Mar 07 '23 09:03 lazybobcat

For those of you feeling brave, I've attached a zip file of the tarball (GitHub does't support attaching tarballs), from which you can do a local install. This is what I've done with my current project as I really don't want to have to publish an NPM package.

angular-google-charts-2.2.3.tgz.zip

oobayly avatar Mar 10 '23 10:03 oobayly

Is there a deadline for approving this pull request?

HenriqueEichstadt avatar Apr 29 '23 17:04 HenriqueEichstadt

Same question here - this library is th only one blocking us to move the project to Angular 15.

funat avatar May 05 '23 09:05 funat

Is there a deadline for approving this pull request?

CristoferEichstadt avatar May 10 '23 19:05 CristoferEichstadt

update to peer dependencies to 16.x ?

mohamed-badaoui avatar May 11 '23 07:05 mohamed-badaoui

Approves the PR, please.

diegoberges avatar May 11 '23 11:05 diegoberges

Is there a possibility to update dependencies to 16.x?

sgovorov avatar Mar 26 '24 11:03 sgovorov

Is there a possibility to update dependencies to 17.x?

mohamed-badaoui avatar Mar 26 '24 11:03 mohamed-badaoui

Why doesn't anyone maintain this project anymore and approve pull requests? If this library is no longer maintained, can't you manage to duplicate, create a new package and take over for future updates? Citing the creator of course

maurodam avatar May 01 '24 07:05 maurodam