vpp icon indicating copy to clipboard operation
vpp copied to clipboard

dmac check is inappropriate

Open yulintao opened this issue 4 weeks ago • 0 comments

`

	 if (ei && (ei->flags & ETHERNET_INTERFACE_FLAG_STATUS_L3))

	 goto skip_dmac_check01;

	  dmacs[0] = *(u64 *) e0;
	  dmacs[1] = *(u64 *) e1;

	  if (ei && vec_len (ei->secondary_addrs))
	    ethernet_input_inline_dmac_check (hi, dmacs,
					      dmacs_bad,
					      2 /* n_packets */ ,
					      ei,
					      1 /* have_sec_dmac */ );
	 ...

`

above this code from ethernet_input_inline if (ei && (ei->flags & ETHERNET_INTERFACE_FLAG_STATUS_L3)) meaning if ei->flags is in l3 mode then skip_dmac_check;

That is wrong, that should be if ei->flags is in promisc mode ,skip dmac check!

So, I think the correct way like this if (ei && (ei->flags & ETHERNET_INTERFACE_FLAG_ACCEPT_ALL));

yulintao avatar Dec 01 '25 12:12 yulintao