FDio
[VPP-1629] test filtering broken in reassembly
Description
commit 6955595a577e1b7d316b5b69267bf1d1d951a4ab breaks test filtering in test_reassembly
e.g.
make test-debug TEST=..test_reassembly
Not running extended tests (some tests will be skipped)
==============================================================================
IPv4 Reassembly for packets coming to ip4-local node
==============================================================================
basic reassembly OK
==============================================================================
TEST RESULTS:
Scheduled tests: 1
Executed tests: 1
Passed tests: 1
==============================================================================
Test run was successful
tests named test_reassembly in IPv4 and IPv6 classes are ignored
Assignee
Paul Vinciguerra
Reporter
Klement Sekera
Comments
- klementsekera (Thu, 28 Mar 2019 23:01:31 +0000): I think you misunderstood me - no test is broken, rather test filtering is broken.
Please consult make test-help and see how TEST= controls which tests are run. Currently, it's impossible to use TEST=test_reassembly.TestIPv4Reassembly.test_reassembly to run only test_reassembly() test from TestIPv4Reassembly class from test_reassembly.py file. This is standard feature from almost day 1 in test framework and very useful when doing TDD. It doesn't work anymore after your change because of the inheritance stuff you introduced.
In my above example (make test-debug TEST=..test_reassembly), three tests should run as there are three test_reassembly() methods in test framework, but only one runs, because the two in the mixin class are ignored and unselectable directly nor by wildcard.
- pvinci (Wed, 27 Mar 2019 13:15:55 +0000): Please see https://gerrit.fd.io/r/#/c/18020/
This was documented as broken on Mar 5, prior to this commit, and you were asked to look into it.
If it turns out that we broke it, we will fix it. Please provide unit tests that should fail, but are passing.
Original issue: https://jira.fd.io/browse/VPP-1629
