govpp icon indicating copy to clipboard operation
govpp copied to clipboard

[vpp repo] Update make go-api-files procedure in VPP repo

Open ondrej-fabry opened this issue 3 years ago • 2 comments

In the VPP repository there is a make target go-api-files for generating Go bindings for VPP binary API from the local API files in the source code. The make target simply executes a Python script generate_go.py that runs go install to get the GoVPP binapi-generator. However it uses some arbitrary commit of GoVPP with the old import path git.fd.io/govpp.git that used before migration to GitHub.

The VPP repository should only use released versions of GoVPP.

Tasks:

  • [ ] update to new import path go.fd.io/govpp
  • [ ] replace global variable DefaultGoVppCommit=xxx with DefaultGoVppVersion=v0.6.0
  • [ ] replace the install procedure for GoVPP for Go older than 1.18 (which is the minimum version) with error "unsupported Go version, please install Go 1.18 or newer"

ondrej-fabry avatar Oct 20 '22 10:10 ondrej-fabry

assign to me

fatelei avatar Oct 22 '22 02:10 fatelei

This could also include updating the documentation page on VPP itself at e.g. https://s3-docs.fd.io/vpp/23.02/interfacing/go/index.html

sknat avatar Nov 03 '22 13:11 sknat