C-PAC icon indicating copy to clipboard operation
C-PAC copied to clipboard

🧹 Harmonize T1-mask pipeline config keys

Open nx10 opened this issue 2 years ago • 2 comments

Related problem

There are many keys in the pipeline config that let users specify T1-masks:

  1. registration_workflows.anatomical_registration.registration.FSL-FNIRT.ref_mask_res-2 https://github.com/FCP-INDI/C-PAC/blob/2a9750c1a0075e5ba3f50ef3f54686d9357591b5/CPAC/resources/configs/pipeline_config_abcd-options.yml#L99
  2. registration_workflows.anatomical_registration.T1w_brain_template_mask https://github.com/FCP-INDI/C-PAC/blob/2a9750c1a0075e5ba3f50ef3f54686d9357591b5/CPAC/resources/configs/pipeline_config_abcd-options.yml#L185
  3. registration_workflows.functional_registration.func_registration_to_template.target_template.T1_template.T1w_brain_template_mask_funcreg https://github.com/FCP-INDI/C-PAC/blob/2a9750c1a0075e5ba3f50ef3f54686d9357591b5/CPAC/resources/configs/pipeline_config_abcd-options.yml#L256
  4. anatomical_preproc.brain_extraction.FreeSurfer-BET.T1w_brain_template_mask_ccs https://github.com/FCP-INDI/C-PAC/blob/2a9750c1a0075e5ba3f50ef3f54686d9357591b5/CPAC/resources/configs/pipeline_config_blank.yml#L269

Proposed feature

Investigate and collapse redundancies across pipelines and maybe move the new key(s) under functional_preproc.func_masking to be more easy to find

Acceptance criteria

  • [ ] Investigated and collapsed redundancies across pipelines
  • [ ] (If sensible) moved new key(s) under functional_preproc.func_masking
  • [ ] Add documentation about what steps are affected by the T1 masks

Alternatives

No response

Additional context

No response

nx10 avatar Dec 11 '23 19:12 nx10

Related: https://github.com/FCP-INDI/C-PAC_templates/issues/24

shnizzedy avatar Dec 11 '23 21:12 shnizzedy

Also related: FCP-INDI/C-PAC#2047

sgiavasis avatar Jan 15 '24 23:01 sgiavasis