Francesco Bruzzesi

Results 281 comments of Francesco Bruzzesi

Hey @ndrezn thanks for taking the time to dive into this. Some overhead for pandas is to be expected as we are adding a layer on top of it, however...

@ndrezn with the latest commit, I am able to get pandas performances on the same ballpark of master on my local machine. Could you check if you are able to...

Improved error messages and expanded on in-line comments in the last two commits. I hope it is more clear now, let me know if something needs to be expanded further

Hey @emilykl thanks a ton! We really appreciated the collaborative effort! As mention on a few meetings, it led us to investigate deeper and improve narwhals codebase significantly as well,...

Hey there! I am taking a look at this and coming up short due to the following: by raising an error during the initialization, then ```py [] == IsListOrTuple ```...

Hey @yuuuxt thanks for reporting the issue. I am not able to replicate on MacOS 🤔 ```py import io import pandas as pd import narwhals as nw import pyarrow print(nw.__version__)...

To me what's also concerning is that our test suite didn't pick that up. We run pyarrow on windows: https://github.com/narwhals-dev/narwhals/blob/bfb61bf93eeaf18784d91baf43354a3ca018ffc2/.github/workflows/pytest.yml#L37

@MarcoGorelli sure that's fair. They are aware and marked https://github.com/apache/arrow/issues/47234 as **critical fix** and _also_ proposed a backport. Still I would expect one of our test to fail 🤔

As an update: the upstream issue has been closed/fixed and they mentioned that the next release (pyarrow 22.0) will be in October

> This PR diff is getting big because of all the `xfail` in tests. 😕 @MarcoGorelli @FBruzzesi do you have a better idea on how to make it more "reviewable"?...