server icon indicating copy to clipboard operation
server copied to clipboard

Published 20 hours ago • verified publisher icon FAForever

Serialize faction as string in game launch message

Open BlackYps opened this issue 3 years ago • 3 comments

Closes #834

BlackYps avatar Sep 13 '21 13:09 BlackYps

One integration test is broken, but I don't know why, because it seems totally unrelated to me. test_game_ratings in test_teammatchmaker.py fails to finish. I found this in the log: WARNING RatingService:rating_service.py:293 gps_update_sql resultset is empty for game_id 41956 It seems like the game_player_stats table fails to update correctly.

BlackYps avatar Sep 13 '21 15:09 BlackYps

You need to make sure the integer value is still used for faction to update the game_stats entries

Sheikah45 avatar Sep 13 '21 15:09 Sheikah45

Codecov Report

Merging #835 (7411a0a) into develop (e2dec4b) will not change coverage. The diff coverage is 100.00%.

Impacted Files Coverage Δ
server/ladder_service.py 98.27% <ø> (ø)
server/types.py 100.00% <100.00%> (ø)

codecov[bot] avatar Sep 15 '21 21:09 codecov[bot]