server icon indicating copy to clipboard operation
server copied to clipboard

Redesign party commands

Open Askaholic opened this issue 5 years ago • 1 comments

It may be better to send party commands using a single command with many subcommands than our current implementation of having a separate command for every action.

We could go with a "polymorphic" approach:

{
    "command": "party",
    "action": "invite",
    "recipient_id": <player_id>
}

Or more of a "compositional" approach:

{
    "command": "party",
    "action": "invite",
    "data": {
        "recipient_id": <player_id>
    }
}

The compositional approach has a little more boilerplate built into the message, but it feels cleaner to me.

Askaholic avatar Jun 03 '20 21:06 Askaholic

I would vote for the polymorphic as all the other commands follow this format. And it would be weird to start mixing them up now.

Sheikah45 avatar Nov 05 '21 21:11 Sheikah45