faf-java-api icon indicating copy to clipboard operation
faf-java-api copied to clipboard

Allow joining public clans w/o invite token

Open bukajsytlos opened this issue 5 years ago • 2 comments

bukajsytlos avatar Nov 28 '20 14:11 bukajsytlos

Looks good. Needs adjustment and co-release on the website before merging.

Brutus5000 avatar Dec 25 '20 22:12 Brutus5000

Codecov Report

Merging #428 (ca8e310) into develop (6c6f388) will increase coverage by 0.14%. The diff coverage is 89.58%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #428      +/-   ##
=============================================
+ Coverage      77.00%   77.15%   +0.14%     
- Complexity      1225     1231       +6     
=============================================
  Files            249      249              
  Lines           3806     3844      +38     
  Branches         241      243       +2     
=============================================
+ Hits            2931     2966      +35     
- Misses           775      778       +3     
  Partials         100      100              
Impacted Files Coverage Δ
...IgnoreOctetStreamToObjectHttpMessageConverter.java 28.57% <ø> (ø)
...api/config/NoopMultipartFileToStringConverter.java 66.66% <ø> (ø)
...n/java/com/faforever/api/clan/ClansController.java 66.66% <50.00%> (+2.38%) :arrow_up:
...ava/com/faforever/api/voting/VotingController.java 9.09% <50.00%> (ø)
...rever/api/data/listeners/ClanEnricherListener.java 88.88% <75.00%> (-11.12%) :arrow_down:
...n/java/com/faforever/api/player/PlayerService.java 71.42% <75.00%> (+4.76%) :arrow_up:
.../main/java/com/faforever/api/clan/ClanService.java 100.00% <100.00%> (ø)
.../main/java/com/faforever/api/data/domain/Clan.java 100.00% <100.00%> (ø)
...c/main/java/com/faforever/api/error/ErrorCode.java 99.15% <100.00%> (+<0.01%) :arrow_up:
...ain/java/com/faforever/api/map/MapsController.java 68.18% <100.00%> (ø)
... and 1 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6c6f388...ca8e310. Read the comment docs.

codecov[bot] avatar Jun 04 '23 20:06 codecov[bot]