FAForever
Fix missing unit param for SpecificUnitsInArea objective type
Issue
Normally when an objective has reached some kind of result (success, failure), depending on its type, it provides the result, and additional data for callback functions to use, like units.
The SpecificUnitsInArea type however is missing that extra data, specifically the destroyed unit if it triggers objective failure.
Right now this oversight breaks the Seraphim mission Tha-Atha-Aez, as the callbacks tries to reference the unit, which is just nil, and basically softlocking the death camera mission failure cinematics. The game has to be closed.
Description of the proposed changes
Simply add the unit as a parameter for OnResult when it's called via the unit's death.
Not only it fixes the map (mostly), it also prevents the same errors for future missions where mission developers want to use the unit via objective callbacks.
Testing done on the proposed changes
The mission Tha-Atha-Aez is relevant for this.
The first 2 allied ACU escort mission failures should trigger proper.
The 3rd however has an error in the map script, there's no unit param defined in the AddResultCallback section, so it's map specific.
I haven't the slightest idea what those changes are.
When I synced my FAF fork, it was simply there.
Edit: Issue lied in my fork using the deploy/fafdevelop branch as the default.
Anyhow, I undid those changes.
@Dhomie The base branch is develop. It used to be deploy/fafdevelop for a long time. The commit originates from the deployment workflow. It helps us identify what game version and what specific git commit the user is running when they share a game log.
For future pull requests, start from develop 😄 !
