fa icon indicating copy to clipboard operation
fa copied to clipboard

Add support for team color mode

Open Garanas opened this issue 7 months ago • 0 comments

Description

Extends https://github.com/FAForever/fa/pull/6726.

Add support for the team color mode. You can toggle it in the multi function menu:

Image

By left clicking the team color mode button you enable or disable it. You can configure the colors by right clicking it.

Course of Action

See also the following comment as a starting point: https://github.com/FAForever/fa/pull/6726#issuecomment-2853466073

The default scoreboard also supports team color mode. You can use that as inspiration.

The solution may require a bit of refactoring. At the moment the responsibility to determine the color of a brush stroke is either in the adapter via ComputeColorOfPeerName or by the brush via GetColorOfActiveBrushStroke. This responsibility should be in the brush stroke class. The input of the function should be the army id of the author of the brush stroke. For observers such an id does not exist - you may default to -1 or nil and just always return a default color.

Test Plan

Observers are an edge case.

Garanas avatar May 07 '25 17:05 Garanas