fa icon indicating copy to clipboard operation
fa copied to clipboard

Move `RollOfUnit()` to after the "finished building" animation

Open lL1l1 opened this issue 1 year ago • 1 comments

Description of the proposed changes

Fixes #5625. UEF and Cybran air factories have an animation that locks the unit's orientation, interfering with the rolloff rotation. The changes move the rolloff rotation to happen after the animation finishes.

Testing done on the proposed changes

Spawn factories, give a rally point on one side, order an engineer, and then change the rally point to the other side before the engineer finishes building and see that it now gets rotated correctly in the UEF and Cybran factories.

   CreateUnitAtMouse('xab1401', 0,    0.14,   -8.65, -0.00000)
   CreateUnitAtMouse('xsb0302', 0,   -4.04,    2.16,  0.00000)
   CreateUnitAtMouse('ueb0302', 0,   11.96,    2.16,  0.00000)
   CreateUnitAtMouse('urb0302', 0,    3.96,    2.16,  0.00000)
   CreateUnitAtMouse('uab0302', 0,  -12.04,    2.16,  0.00000)

Checklist

  • [x] Changes are annotated, including comments where useful
  • [x] Changes are documented in the changelog for the next game version

lL1l1 avatar Sep 21 '24 22:09 lL1l1

This fixes it but the code style may be sloppy, although I think it's the most efficient solution.

lL1l1 avatar Oct 23 '24 12:10 lL1l1

Tested and works as expected, in addition to being an important change for gameplay.

Basilisk3 avatar Nov 03 '24 16:11 Basilisk3

We'll include this one as well because we now have more time for testing with the delayed release

BlackYps avatar Nov 24 '24 13:11 BlackYps