Move `RollOfUnit()` to after the "finished building" animation
Description of the proposed changes
Fixes #5625. UEF and Cybran air factories have an animation that locks the unit's orientation, interfering with the rolloff rotation. The changes move the rolloff rotation to happen after the animation finishes.
Testing done on the proposed changes
Spawn factories, give a rally point on one side, order an engineer, and then change the rally point to the other side before the engineer finishes building and see that it now gets rotated correctly in the UEF and Cybran factories.
CreateUnitAtMouse('xab1401', 0, 0.14, -8.65, -0.00000)
CreateUnitAtMouse('xsb0302', 0, -4.04, 2.16, 0.00000)
CreateUnitAtMouse('ueb0302', 0, 11.96, 2.16, 0.00000)
CreateUnitAtMouse('urb0302', 0, 3.96, 2.16, 0.00000)
CreateUnitAtMouse('uab0302', 0, -12.04, 2.16, 0.00000)
Checklist
- [x] Changes are annotated, including comments where useful
- [x] Changes are documented in the changelog for the next game version
This fixes it but the code style may be sloppy, although I think it's the most efficient solution.
Tested and works as expected, in addition to being an important change for gameplay.
We'll include this one as well because we now have more time for testing with the delayed release