fa icon indicating copy to clipboard operation
fa copied to clipboard

Update the Naming consistency of Support land factory's

Open MrRowey opened this issue 1 year ago • 1 comments

Checklist

  • [x] Changes are documented in the changelog for the next game version

MrRowey avatar Jul 03 '24 17:07 MrRowey

  1. What is this consistent with? The cheat menu has "(Support)" appended to the descriptions, which isn't what you put here.

    • The cheat menu would have to have that appendation removed if the descriptions are changed to indicate that it is a support factory. https://github.com/FAForever/fa/blob/8b6f9ecaef2be28219127cdf5f68249584230896/lua/ui/dialogs/createunit.logic.lua#L91-L92
  2. You need to update the localization in loc/[language]/strings_db.lua for your changes to show up in the UI.

  3. I think it's fine to update the names for all the support factories in one pull request.

  4. You should describe how you found this issue with the factory names and what you tested to make sure the names show, or that you tried and couldn't figure it out and wanted some help.

I've updated these due to the fact this doesn't reflect in the unit db like spooky but I will look at the changes you proposed

MrRowey avatar Jul 03 '24 19:07 MrRowey