fa icon indicating copy to clipboard operation
fa copied to clipboard

Common Army

Open KionX opened this issue 2 years ago • 9 comments

New lobby options. Modifies team management.

  • Union control for team: You can switch focus between allies. Works best with "Shared radar intel ranges"

  • Uses a single army for team: With one army per team. No need to switch focus, shared resources and units.

The number of ACUs, AIs and the locations do not change.

Uses https://github.com/FAForever/FA-Binary-Patches/commit/fd7b0893d0efb72ed015b0736fee058576d0bcd7

KionX avatar Aug 16 '22 15:08 KionX

Is this similar to the shared army modification?

Garanas avatar Aug 16 '22 15:08 Garanas

Yes. And I have already done similar things in Coop.

KionX avatar Aug 16 '22 15:08 KionX

Exciting, could you tell me how it works in practice?

Garanas avatar Aug 16 '22 15:08 Garanas

Updated description.

KionX avatar Aug 16 '22 16:08 KionX

I understand now, that sounds exciting 👍 , I'll adjust the english translations slightly

Garanas avatar Aug 16 '22 16:08 Garanas

This looks interesting. Would this basically obsolete the share condition when enabled, keeping all units alive similarly to how full share does? If so, perhaps it should be listed as a new share condition in the lobby options instead of as another type of option?

Penguin5 avatar Aug 19 '22 14:08 Penguin5

This is not related to the share condition.

KionX avatar Aug 19 '22 16:08 KionX

Okay, neat. I really like this idea.

Penguin5 avatar Aug 19 '22 16:08 Penguin5

We'll merge it after the release is stable, for testing on FAFDevelop

Garanas avatar Aug 19 '22 16:08 Garanas

@KionX

Dude, thats AWESOME !!!

Uveso avatar Aug 20 '22 13:08 Uveso

I think I've done enough.

KionX avatar Aug 22 '22 08:08 KionX

I'll review it and make changes accordingly, once we're certain that the last release is stable I'll merge it in. Great job, looking forward to it!

Garanas avatar Aug 22 '22 08:08 Garanas

Up

KionX avatar Sep 24 '22 15:09 KionX

Apologies for it taking so long, I've tested it, and it appears to work like a charm! I've adjusted the English description to be more descriptive, exactly telling you what you're getting yourself into as a player. I've also turned it into a team option instead of a global option, as it feels like it fits there better.

Garanas avatar Oct 01 '22 07:10 Garanas

@KionX / @4z0t could either of you look at the Russian translation, make it match the English one? After that this PR can get merged in by either me or @Hdt80bro

Garanas avatar Oct 01 '22 07:10 Garanas

Ive been playing a lot of shared armies lately and have been rather unimpressed with the performance lately. Its exciting to know that a better version will be made available. Whats the ETA on this change being added to faf dev? Will this fix the common shared army issues such as units not responding to orders and difficulty selecting acus at the start of games?

Spikey84 avatar Oct 02 '22 21:10 Spikey84

Merge this.

KionX avatar Oct 04 '22 12:10 KionX

I just tested this feature and there seems that there are issues (assuming i am using the feature as intended). When i did a 2v2 with shared control and 1 army, the game launched and only allowed us to use 1 acu(as intended) but instead of the enemy having their own armys, they were on my army as well. My understanding that it should work like shared armies (the mod) and each team 1 army that they can all control. A video of the game can be seen on https://www.twitch.tv/stellartactician 's latest vod. Replay is https://replay.faforever.com/18218863

Spikey84 avatar Oct 08 '22 00:10 Spikey84

It should be working properly now.

KionX avatar Oct 09 '22 16:10 KionX