fa icon indicating copy to clipboard operation
fa copied to clipboard

Increase modularity and testability in PenguinAutoBalance

Open Penguin5 opened this issue 2 years ago • 4 comments

Increases modularity/testability for the new autobalancer via the DetermineTeams function, which can generate testing data by being called with (true, true)

Penguin5 avatar Apr 28 '22 15:04 Penguin5

This is great - is it decoupled enough that you could place it in another file, and import that accordingly? That would reduce the amount of code in the lobby.

Garanas avatar Apr 28 '22 17:04 Garanas

Theoretically, but when I tested that, it would not work in its current location (for the in-lobby autobalance button) because of an error for too many upvalues (limit of 32).

Penguin5 avatar Apr 28 '22 19:04 Penguin5

Ah, yes - that is a known issue 😞 .

Garanas avatar Apr 29 '22 06:04 Garanas

So, can this be merged?

Penguin5 avatar Oct 02 '22 15:10 Penguin5