downlords-faf-client
downlords-faf-client copied to clipboard
Inconsistent map and mod detail cards
The map detail shows a description heading whereas the mod detail does not. In my opinion the heading can be removed as it is pretty self-explanatory that the following text is a description. In any way it should be consistent between the two.
I also just noticed that they don't use the rolling in window like the map/mod upload but instead still use the old way of displaying a window. This should probably also be fixed.
What do you mean by rolling in window?
It's what happens when you use uiService.showInDialog()
ah well they aren't really an old way and a new way. They are just two different types of displays used for different things.
I called it old and new, because the overlay has been changed from the "old" way to showing things in dialog some time ago. The issue I see with the "old" way is that the window has a fixed distance from the client border. So in fullscreen it blows the window up bigger than it needs to. This not only looks a bit bad, but is also annoying because you have to move your mouse all the way to the border to close the window. The showInDialog way only uses as much space as the elements need.