client icon indicating copy to clipboard operation
client copied to clipboard

Published 20 hours ago • verified publisher icon FAForever

Contribution instructions

Open duk3luk3 opened this issue 8 years ago • 3 comments

  • [x] Need issue and PR templates
  • [X] Need more detailed instructions for contribution (#465)
  • [ ] Need a python styleguide

@Sheeo can I have enough access to the repo so I can make issue and PR templates?

duk3luk3 avatar Nov 07 '16 18:11 duk3luk3

Setting up contribution instructions (or guidelines as I like to call them) are IMO the first step in getting a project (back) on track. So I'm in for this.

For templates: please choose them wisely; different issues require different templates (e.g. bug report vs. feature request) and I've seen too many templates which just didn't fit what I was reporting; those were rather unhelpful. But if made well, they can be a big help. No more "It doesn't work" issues ;)

Also, feel free to copy some contribution guidelines I've created: https://github.com/FAForever/downlords-faf-client/wiki/Contribution-guidelines

micheljung avatar Nov 08 '16 17:11 micheljung

@Sheeo @micheljung Please check out #472!

duk3luk3 avatar Nov 10 '16 06:11 duk3luk3

For the styleguide, we could adopt PEP 8 and use the pep8 package to automatically lint it.

duk3luk3 avatar Nov 10 '16 20:11 duk3luk3