process-compose icon indicating copy to clipboard operation
process-compose copied to clipboard

Allow headers on http probes

Open jcmuller opened this issue 1 year ago • 1 comments

Feature Request

Use Case:

Vite dev server supports ping requests. Not on a path (why would it /s) but instead when passing in the Accept: text/x-vite-ping header.

I would much prefer to use the native http probe rather than having to use an exec one and using curl or similar.

Proposed Change:

Allow headers to be passed into the HTTP liveness and readiness probes.

Who Benefits From The Change(s)?

At least anyone who wants to use vite. There will be other cases.

Alternative Approaches

Use an exec probe with curl or similar.

jcmuller avatar Sep 27 '24 13:09 jcmuller

If this seems like a good idea I can submit a patch for it.

jcmuller avatar Sep 27 '24 13:09 jcmuller

Hi @jcmuller,

It is a very good idea. A PR is more than welcome.

F1bonacc1 avatar Mar 16 '25 16:03 F1bonacc1