arduino-dw1000-ng icon indicating copy to clipboard operation
arduino-dw1000-ng copied to clipboard

ESP32: delegate interrupt handling into a separate task

Open avillacis opened this issue 4 years ago • 4 comments

This pull request switches the interrupt request handling from a direct ISR into a separate task. This allows the handler more flexibility in how to handle the interrupt, without violating timing limits that may cause lockups or watchdog reboots. For platforms other than ESP32, the behavior of the code has been preserved.

Q A
Bug fix? yes
New feature? no
Doc update? no
BC breaks? no
Deprecations? no
Relative Issues #

avillacis avatar Aug 12 '20 22:08 avillacis

Can you please explain the differences between this and #164 ? Are they trying to achieve the same functionality? Sorry if we ask but we didn't use much the ESP32

Anacron-sec avatar Aug 19 '20 20:08 Anacron-sec

@zrecore Are you available to try out these improvements (this and #177) ? Thank you

Anacron-sec avatar Aug 19 '20 20:08 Anacron-sec

I'll have a look on Saturday. 👍

On Wed, Aug 19, 2020, 1:45 PM Michele Biondi [email protected] wrote:

@zrecore https://github.com/zrecore Are you available to try out these improvements (this and #177 https://github.com/F-Army/arduino-dw1000-ng/pull/177) ? Thank you

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/F-Army/arduino-dw1000-ng/pull/178#issuecomment-676683971, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADIW3G42D4NGCHEUNIPVQ3SBQ2XNANCNFSM4P5M42DA .

zrecore avatar Aug 20 '20 10:08 zrecore

Can you please explain the differences between this and #164 ? Are they trying to achieve the same functionality? Sorry if we ask but we didn't use much the ESP32

It seems that #164 has the same purpose as my commit. However, my version does not change the library API, and since the task has a higher priority than the ordinary code, it should be less prone to handling delays.

avillacis avatar Aug 24 '20 16:08 avillacis

We are closing pull requests with merging conflicts as we are archiving the repo, feel free to create your own fork if you intend to support the project, we will be happy to add a link on this project.

Anacron-sec avatar Nov 09 '23 12:11 Anacron-sec