chaos-stream-proxy icon indicating copy to clipboard operation
chaos-stream-proxy copied to clipboard

parse dash manifest if segment template is out of representation

Open brignolij opened this issue 2 years ago • 9 comments

Improve dash parsing by fetching segment template in manifest if located out of representation.

brignolij avatar Apr 14 '23 11:04 brignolij

Works perfectly with my DASH manifest !

Thanks @brignolij !

hugohlln avatar Apr 25 '23 08:04 hugohlln

Thank you for the contribution! We've just added segment template support so if you can rebase with main again and check I can have a look at the PR then.

birme avatar Apr 25 '23 10:04 birme

Hello @birme we have change some part of the code cause with our stream provider some parts didn't work. And I don't know if it's okay for you but I had change some tests because the player https://web.player.eyevinn.technology/index.html wasn't able to decode url encoded, I hope it'll be good for you. Thank to you

m-conti avatar Apr 26 '23 10:04 m-conti

and in the HLS part I've remove a part because it was already include in the package '@eyevinn/m3u8'

m-conti avatar Apr 26 '23 10:04 m-conti

Thanks, we'll review!

birme avatar Apr 26 '23 10:04 birme

Btw. can you rebase, fix linting issues and resolve the conflicts with main first though.

birme avatar Apr 26 '23 10:04 birme

@ShibireX we rebased our branch. Regards

brignolij avatar May 08 '23 06:05 brignolij

Sorry, but can you rebase with main again and resolve any conflicts? Thanks

birme avatar May 17 '23 06:05 birme

hello @birme, we still do some changes cause with different manifest and provider we have some issues. We will do some tests on different type of (stream / manifest / providers / players) before rebase. I think after all of this we will need another review. I've do some workaround maybe you can find some better solutions

m-conti avatar May 17 '23 17:05 m-conti