Zinnia.Unity icon indicating copy to clipboard operation
Zinnia.Unity copied to clipboard

AngleToVector2Direction the conversion is not conventional

Open fight4dream opened this issue 4 years ago • 1 comments

my intuition of it is given an angle, say DoTransform(30degs), it will output Transformed(Vector2( cos(30degToRad), sin(30degToRad) )) after wired things up, i discover it isn't. so the code says:

  1. there is an internal 'currentAngle', we'll increment it by the input angle every time we call transform,
  2. the direction is normalized by 1f / Mathf.Max(Mathf.Abs(Direction.x), Mathf.Abs(Direction.y));

so i guess it is made this way because of input axis prefab needed this kind of manipulation, but comparing this component among others, it shouldn't have incremented a hidden angle, some components that provides increment feature would have both Set() and Increment()

also the special normalization would better be another component's duty

fight4dream avatar Apr 22 '21 02:04 fight4dream

Is this a bug report or a feature request?

If it's a bug report then provide steps to reproduce with expected and actual

If it's a feature request the provide outline of the benefit of the feature

thestonefox avatar Apr 22 '21 10:04 thestonefox