Can we merge BehaviourEnabledObserver and RulesMatcher?

[bddckr]

BehaviourEnabledObserver definitely should take a Rule instead, at which point it's very similar to RulesMatcher. Perhaps the repeated invoking can be done as a standalone component that repeatedly calls an IProcessable.Process until canceled?

[bddckr]

• BehaviourEnabledObserver == IProcessable + a new IRule that does a list check for all behaviours being enabled
• RulesMatcher
• this new "ProcessCaller"

[fight4dream]

Before

After

Initial thoughts and decisions involved:

RulesMatcher

RulesMatcher matches a list of rules against the same object (behaviour), whereas BehaviourEnabledObserver matches a single rule (isActiveAndEnabled) against all behaviour in the list. So they are not quite compatible.

a new IRule that does a list check for all behaviours being enabled

IRule interface only Accept(object) a single object. It is incompatible with matching each behaviour in the list. Sounds like a ICollectionRule.Accept(ObservableList).

IsActiveAndEnabledRule

IsActiveAndEnabledRule was the first thing I write. In retrospect, the current BehaviourEnabledObserver2 can use any rule, so it is actually not that specific and more like a BehaviourRuleMatcher. I'm not sure about the difference between RulesMatcher and AllRules but I guess it depends on usage. Anyway, we can keep it specific and check isActiveAndEnabled inside the observer just like the previous version.

bddckr commented that:

The issue now is

1. Users have to add many more components
2. All prefabs need to be updated :slightly_smiling_face: