Dmitrii Aleksandrov
Dmitrii Aleksandrov
Thank you! I'll review this a bit later. TODO for myself: also merge this in `master` (2.0.0). If you're ok with using your own unreleased fork of 1.1.x until 2.0.0...
Yeah, I assumed that you may want that. I'm not the one making (the decisions about) releases, but @tyt2y3 will probably do this
Thank you. `zip` yanks broke `cargo update` in my project too, now I depend on your fork
@tafia, I wrote you an email and opened #516 with a plan to find more maintainers. Let's coordinate our efforts there. I'm sure that plenty of people depend on your...
If you don't mind, I'll review when the CI passes. But feel free to ask if you need my review earlier
> I don't think it's a good practice to name this method to_string as it conflicts with the Display trait method, which violates Rust conventions. I suggest renaming it I...
> I would probably even not put in the `deprecated` notice to avoid causing tons of compiler warnings in the first release. Yeah, agree. Definitely not in `1.0.0`. > I...
@Huliiiiii, we've chatted with Chris and decided to split the PR in order to proceed. Initially, we want to merge these two small changes as separate PRs: - `impl Iden...
Agree, it's very annoying
Sounds good. Added this to https://github.com/SeaQL/sea-orm/discussions/2548