Local build ignores build flag in user_defines

[slackista]

Current Behavior

Local build ignores build flag -DRegulatory_Domain_EU_868

Steps to Reproduce

1. Select Git branch tab
2. Select master branch
3. Target: radiomaster.tx_dual.nomad.uart
4. Manual mode:

-DMY_BINDING_PHRASE="secret"
-DRegulatory_Domain_EU_868
-DUART_INVERTED

5. Logs don't print build_flags
6. Build and flash finishes without errors
7. TX is flashed successfully with AU915 reg domain

Details

Configurator v1.7.6 Reproducible on ArchLinux and Debian11

[pkendall64]

Can you attach the log from the build please?

[slackista]

Build logs. Vanilla Ubuntu24.04.1 expressslrs-configurator.log

[pkendall64]

@jurgelenas The issue here is that after the firmware has been built, configurator is calling the binary_configurator.py script and it can't set the options because they are defines in the manual mode text box. Basically when doing a local build of firmware configurator should not be calling the configurator as all the values should be set in place by the platformio build.

This will affect all locally built firmwares from the "git" and "local" tabs in configurator.

[slackista]

Any chance to fix this? Local build for LR1121 via Confgurator is broken since beginning.

[jurgelenas]

Feature removed in #737

[broskicodes]

Hi @jurgelenas. I was wondering is there is any way to add custom user defines when flashing a local build via configurator?

I understand that you removed manual mode because of some unintended behaviour, but is there any alternative that allows user defines to be set properly? I have tried editing the local user_defines.txt file, but it gets overwritten when I run flash through configurator ui.

[jurgelenas]

Hi @jurgelenas. I was wondering is there is any way to add custom user defines when flashing a local build via configurator?

I understand that you removed manual mode because of some unintended behaviour, but is there any alternative that allows user defines to be set properly? I have tried editing the local user_defines.txt file, but it gets overwritten when I run flash through configurator ui.

Just use vscode and platformio :)