ExpressLRS-Configurator icon indicating copy to clipboard operation
ExpressLRS-Configurator copied to clipboard

Update locale codes to fix Simplified Chinese Crowdin issue

Open L1cardo opened this issue 1 year ago • 3 comments

The Simplified Chinese localization uses zh-CN, instead of zh, so we may want to change %two_letters_code% into %locale%, according to https://developer.crowdin.com/configuration-file/#placeholders

https://github.com/ExpressLRS/ExpressLRS-Configurator/blob/a7e58082d8c551d83f0a8efe175e46a95238362d/crowdin.yml#L11

L1cardo avatar Apr 17 '24 02:04 L1cardo

Another option is to "change" only the %two_letters_code% that you need. This is how is done in Betaflight Configurator (in this case to change the - for _ but you can change it for what you want): https://github.com/betaflight/betaflight-configurator/blob/322a198165aee0d296fed6514b711b234c8aeb9a/crowdin.yml#L24-L34

It depends if you plan to use dialects at some moment. For example Portuguese from Brazil and from Portugal.

McGiverGim avatar Apr 17 '24 10:04 McGiverGim

I forgot to say that in Crowdin you can directly do the same: image

McGiverGim avatar Apr 17 '24 10:04 McGiverGim

I forgot to say that in Crowdin you can directly do the same: image

I don't have that permission to change settings.

L1cardo avatar Apr 17 '24 10:04 L1cardo

I forgot to say that in Crowdin you can directly do the same: image

I don't have that permission to change settings.

I have changed the settings:

image

@L1cardo please let me know if everything is alright on your end? I have also updated translations in https://github.com/ExpressLRS/ExpressLRS-Configurator/commit/ff68f6397223ae37d41233bb73e543a2ed4e93f6

jurgelenas avatar May 14 '24 09:05 jurgelenas

Yeah, looks like this would fix the problem, thanks

L1cardo avatar May 14 '24 15:05 L1cardo