Kang-Che Sung (宋岡哲)

Allow me to restate my concerns about this PR? Generally I don't like the idea of having a per-meter `supportedMode` flags. 1. There are only 5 meter modes for htop...

@BenBE When I wrote #714 I intended the mode to replace the current graph mode implementation, not as an alternative "1a/1b" as you say. I think you are referring to...

I'm curious about one thing. Since this patch would disable certain modes for certain meters, what would happen if the user has an htop configuration that sets a meter to...

I have some experimental changes that you could consider merging with this feature. See this branch: https://github.com/Explorer09/htop-1/tree/meter-next-mode In particular, these two commits: * [Remove CUSTOM_METERMODE special handling](https://github.com/Explorer09/htop-1/commit/d70b8cc7369dcbd0757e2c13e6a053c68904f808) * [Meter_nextSupportedMode() function](https://github.com/Explorer09/htop-1/commit/25388969d4df6a123ddac561a66a37188837c738)

> I noticed a small issue with the LED mode of the Battery meter: When you switch from LED mode to Text mode, you see the LED mode text until...

@BenBE By the way. I feel little uncomfortable when we allow a `supportedModes` field to be zero. If possible, I would like all meters to have explicit `supportedModes`. This would...

> > > I noticed a small issue with the LED mode of the Battery meter: When you switch from LED mode to Text mode, you see the LED mode...

> It's a matter of the displayed text being cached and still wrong. There is a redraw done already. > Or maybe call Meter.draw() to force updating the cache? I...

Please pull in these two patches to your PR: https://github.com/Explorer09/htop-1/commit/252c88218b90b16a8957c4197136fa5d26829767 "Restrict supported modes for (more) text-only meters" https://github.com/Explorer09/htop-1/commit/98f0ce36d9f2b3e7b0ec955bb6ccbfd8e76c42c5 "Explicitly specify supported modes of all meters"

> Anything else to do in your opinion? Otherwise I'd go ahead an merge this one soon … Nothing except that 9f315bb6e28e93c7756100c6e149cf6fb2d9122c and 252c88218b90b16a8957c4197136fa5d26829767 may be squashed together during merging.