react-native-live-markdown icon indicating copy to clipboard operation
react-native-live-markdown copied to clipboard

Migrate from `NSLayoutManager` to `NSTextLayoutManager`

Open tomekzaw opened this issue 1 year ago • 1 comments
trafficstars

Details

Closes https://github.com/Expensify/react-native-live-markdown/issues/145.

[!CAUTION] NSTextLayoutManager is available since iOS 16. On older versions of iOS, blockquote ribbon will not be drawn.

Related Issues

GH_LINK

Manual Tests

Linked PRs

tomekzaw avatar Oct 18 '24 19:10 tomekzaw

I think that maybe we should consider leaving previous solution as a fallback for iOS versions lower than 16. iOS 16 is a very recent update so it is possible that someone would want to use this on earlier versions.

Other than that this PR looks great in my opinion! 🎉

maksg avatar Nov 04 '24 11:11 maksg

@maksg I've added fallback for iOS 15 and older in 7e56e5e68e158d1fe5c93d221f6a1d28d5b85992

tomekzaw avatar Jul 17 '25 11:07 tomekzaw

TextKit 1 TextKit 2
Screenshot 2025-07-17 at 13 30 22 Screenshot 2025-07-17 at 13 32 15

tomekzaw avatar Jul 17 '25 11:07 tomekzaw

:rocket: Published to npm in 0.1.295 :tada:

os-botify[bot] avatar Jul 17 '25 15:07 os-botify[bot]