react-native-live-markdown icon indicating copy to clipboard operation
react-native-live-markdown copied to clipboard

Add `MarkdownText` component for preview

Open tomekzaw opened this issue 1 year ago β€’ 25 comments

Work in progress. Closes #93.

tomekzaw avatar Jan 16 '24 11:01 tomekzaw

Can't wait for this!

Will it also have web support?

nandorojo avatar Feb 08 '24 12:02 nandorojo

Yes, it will support web, in fact this is the easiest part here πŸ˜„

tomekzaw avatar Feb 08 '24 12:02 tomekzaw

Can’t wait for it to get released πŸ™

nandorojo avatar Feb 08 '24 12:02 nandorojo

This is great! πŸš€ @tomekzaw are there any blockers for shipping this?

pzatorski avatar Feb 28 '24 11:02 pzatorski

If I were to guess, it would be Android and Web support, as the PR appears to only have ios code for now.

@tomekzaw should I try to add web support here to help push things forward?

nandorojo avatar Mar 03 '24 16:03 nandorojo

@pzatorski Thanks! First we need to address some issues related to MarkdownTextInput component, especially for web. Once completed, we will return to this draft PR.

@nandorojo Implementing web version of MarkdownText component is the cherry on top; I'm afraid that adding it now won't make things much faster for us. Anyway, if you'd like to give it a shot then feel free to go ahead, I won't stop you πŸ˜‰

tomekzaw avatar Mar 03 '24 21:03 tomekzaw

Hi, any progress with this?

peter-olom avatar Apr 06 '24 18:04 peter-olom

Can't wait!

arasrezaei avatar Apr 13 '24 09:04 arasrezaei

When will be available?

arasrezaei avatar Apr 21 '24 00:04 arasrezaei

When will be available?

sergeymild avatar Jul 29 '24 15:07 sergeymild

Any news ?

SuperBesse avatar Aug 09 '24 08:08 SuperBesse

what are you guys using for rendering ?

southkeys avatar Sep 07 '24 14:09 southkeys

Any news?

csulit avatar Oct 01 '24 04:10 csulit

what are you guys using for rendering ?

Gautammer avatar Oct 07 '24 13:10 Gautammer

Hi, any update on this?

bbaoNg97 avatar Nov 04 '24 08:11 bbaoNg97

Hi, we'd like to first merge https://github.com/Expensify/react-native-live-markdown/pull/520 and then use an analogous approach in this PR.

tomekzaw avatar Nov 04 '24 08:11 tomekzaw

any updates?

arasrezaei avatar Dec 27 '24 11:12 arasrezaei

Is it performant enough to just use it as a disabled input component?

markwitt1 avatar Jan 31 '25 14:01 markwitt1

@markwitt1 Yes, but there are some layout-related differences between Text and TextInput. If you're fine with those, you can just use a disabled TextInput solely for Markdown rendering.

tomekzaw avatar Jan 31 '25 14:01 tomekzaw

how about in a list? any perf considerations?

ice-cap0 avatar Feb 09 '25 19:02 ice-cap0

@tomekzaw any updates on this PR / #520 ? Will be good to know to factor in which library we are using.

I guess using a disabled TextInput input could work, although we will also need it in a list, so I guess I would also want to know the answer to the above about performance in a list

ericpoulinnz avatar May 10 '25 02:05 ericpoulinnz

@ericpoulinnz There are no updates on this PR. As for #520, I'm currently working on adapting it to RN 0.79.1+.

When it comes to using a disabled MarkdownTextInput inside a list, probably no one tried it before so we don't have any idea about its performance, but hopefully this should be quite straightforward for you to measure.

tomekzaw avatar May 10 '25 07:05 tomekzaw

Thanks for the quick response @tomekzaw .

The performance was not too bad from my quick tests, but ran into the (obvious in hindsight) issue that links are not clickable in the TextInput mode (as far as I can see?)

So I will use another solution for the meantime but eagerly await this PR being merged in :)

ericpoulinnz avatar May 10 '25 21:05 ericpoulinnz