Bedrock icon indicating copy to clipboard operation
Bedrock copied to clipboard

[WIP] Conflict free journal

Open tylerkaraszewski opened this issue 1 year ago • 2 comments

Details

Currently (6aa3d6f) This will reserve journal tables even if we have a different conflict on subsequent attempts after a single conflict on a journal table It seems to deadlock or something. Not sure if those are related.

Fixed Issues

Fixes GH_LINK

Tests


Internal Testing Reminder: when changing bedrock, please compile auth against your new changes

tylerkaraszewski avatar Oct 20 '23 18:10 tylerkaraszewski

The above actually does pass in dev eventually (it's slow) so I don't think there's a deadlock issue, but some different contention issue.

Edit: maybe not, it passes sometimes. I have logs locally to look at.

tylerkaraszewski avatar Oct 24 '23 00:10 tylerkaraszewski

Note: I think its possible that we end up with a bunch of threads trying to grab journals in prepare but they're all taken. We've introduced a deadlock condition I think where we need to get a journal lock and a commit lock, and we might not grab them both in the same order all the time.

That's speculative but I want to write it down before I stop on this for the day.

tylerkaraszewski avatar Oct 24 '23 00:10 tylerkaraszewski