Bedrock
Bedrock copied to clipboard
[WIP] Conflict free journal
Details
Currently (6aa3d6f) This will reserve journal tables even if we have a different conflict on subsequent attempts after a single conflict on a journal table It seems to deadlock or something. Not sure if those are related.
Fixed Issues
Fixes GH_LINK
Tests
Internal Testing Reminder: when changing bedrock, please compile auth against your new changes
The above actually does pass in dev eventually (it's slow) so I don't think there's a deadlock issue, but some different contention issue.
Edit: maybe not, it passes sometimes. I have logs locally to look at.
Note: I think its possible that we end up with a bunch of threads trying to grab journals in prepare
but they're all taken. We've introduced a deadlock condition I think where we need to get a journal lock and a commit lock, and we might not grab them both in the same order all the time.
That's speculative but I want to write it down before I stop on this for the day.