Remove loading screen logs

[thienlnam]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

As part of https://github.com/Expensify/App/issues/7424, we added logs to help identify locations where slow spinners appear. Now that we've resolve the issue of slow spinners, should we remove the logs or have they been helpful in debugging other loading screen issues?

[thienlnam]

Still holding

[thienlnam]

Not really used, though I think we can revisit this in a month after we complete the api refactors to see if it provides any additional debugging assistance

[thienlnam]

Same as above, logs haven't been useful for now

[thienlnam]

Same

[thienlnam]

I think this is fine to remove, we haven't used it - will get a PR up later

[thienlnam]

Haven't done this, not really a priority

[thienlnam]

Same as above, here is the PR https://github.com/Expensify/App/pull/8347

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~012d8e2262399c8ead

[melvin-bot[bot]]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @mollfpr (Internal)

[melvin-bot[bot]]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot[bot]]

Bug0 Triage Checklist (Main S/O)

• [ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• [ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• [ ] This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• [ ] This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• [ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[thienlnam]

Adding 'Internal' and BugZero so we can make sure to pay out @mananjadhav for reviewing the PR here https://github.com/Expensify/App/pull/14374

Not yet on production and so will still have to wait for that

[sakluger]

Just sent an offer to @mananjadhav in Upwork!

[mananjadhav]

Thanks @sakluger. Accepted

[thienlnam]

7 day regression wait is done 01-30-23

This is a pretty small bug so I don't imagine any problems though 👍

[mananjadhav]

Quick bump @sakluger

[thienlnam]

@mananjadhav There doesn't seem to be anything actionable here, payment date will be 01-30-23. Sorry if I didn't make that clear in my last comment

[mananjadhav]

Sorry my bad @thienlnam @sakluger. I read this as Jan 23, instead of 2023.

[thienlnam]

No problem! 😄

[mananjadhav]

@sakluger Quick bump on the payout.

[sakluger]

Sorry for the delay and thanks for the bump. I paid through Upwork, thanks everyone!