workflow approval limit followup

[abzokhattab]

Explanation of Change

Fixed Issues

$ https://github.com/Expensify/App/issues/78316 https://github.com/Expensify/App/issues/78320 https://github.com/Expensify/App/issues/78324 https://github.com/Expensify/App/issues/78327 https://github.com/Expensify/App/issues/78328 https://github.com/Expensify/App/issues/78342 https://github.com/Expensify/App/issues/78343 PROPOSAL:

Tests

• [ ] Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

• [ ] Verify that no errors appear in the JS console

PR Author Checklist

• [ ] I linked the correct issue in the ### Fixed Issues section above
• [ ] I wrote clear testing steps that cover the changes made in this PR
  • [ ] I added steps for local testing in the Tests section
  • [ ] I added steps for the expected offline behavior in the Offline steps section
  • [ ] I added steps for Staging and/or Production testing in the QA steps section
  • [ ] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • [ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • [ ] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• [ ] I included screenshots or videos for tests on all platforms
• [ ] I ran the tests on all platforms & verified they passed on:
  • [ ] Android: Native
  • [ ] Android: mWeb Chrome
  • [ ] iOS: Native
  • [ ] iOS: mWeb Safari
  • [ ] MacOS: Chrome / Safari
• [ ] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• [ ] I verified there are no new alerts related to the canBeMissing param for useOnyx
• [ ] I followed proper code patterns (see Reviewing the code)
  • [ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • [ ] I verified that comments were added to code that is not self explanatory
  • [ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • [ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • [ ] If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • [ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • [ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • [ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • [ ] I verified the JSDocs style guidelines (in STYLE.md) were followed
• [ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• [ ] I followed the guidelines as stated in the Review Guidelines
• [ ] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• [ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• [ ] I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• [ ] I verified that if a function's arguments changed that all usages have also been updated correctly
• [ ] If any new file was added I verified that:
  • [ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• [ ] If a new CSS style is added I verified that:
  • [ ] A similar style doesn't already exist
  • [ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• [ ] If new assets were added or existing ones were modified, I verified that:
  • [ ] The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • [ ] The assets load correctly across all supported platforms.
• [ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• [ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• [ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• [ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• [ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • [ ] I verified that all the inputs inside a form are aligned with each other.
  • [ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• [ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• [ ] I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• [ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[codecov[bot]]

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/SCREENS.ts	100.00% <ø> (ø)
src/components/ApproverSelectionList.tsx	0.00% <ø> (ø)
...rc/components/Icon/chunks/expensify-icons.chunk.ts	0.00% <ø> (ø)
...gation/linkingConfig/RELATIONS/WORKSPACE_TO_RHP.ts	100.00% <ø> (ø)
src/libs/Navigation/linkingConfig/config.ts	75.00% <ø> (ø)
src/libs/WorkflowUtils.ts	85.51% <100.00%> (+1.77%)	:arrow_up:
src/pages/workspace/withPolicy.tsx	100.00% <ø> (ø)
...ges/workspace/workflows/WorkspaceWorkflowsPage.tsx	0.00% <ø> (ø)
src/styles/index.ts	46.55% <ø> (ø)
src/components/AmountForm.tsx	0.00% <0.00%> (ø)
... and 14 more
... and 61 files with indirect coverage changes

[abzokhattab]

There is also a bug in the Expenses From step where if the user deletes a member offline and creates a new workflow the user will still show up in the Expenses From` step..

fixed it

[aimane-chnaif]

I think it's better to revert original PR and fix all regressions in v2. There are core blockers: https://github.com/Expensify/App/pull/76032#discussion_r2642852992

[abzokhattab]

Not a bad idea ,,, i think most of them are small issues but i agree for the amount its imporant to maintain the behaviour for VND currency and negative amount ... this was overlooked.

lets revert and i will prepare another PR

what do u think @JS00001

[aimane-chnaif]

Here's revert

[melvin-bot[bot]]

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

1. Look at the code and make sure there are no malicious changes.
2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

[abzokhattab]

I've fixed all the issues except for the following 4, where I need clarification on the expected behavior @JS00001 @aimane-chnaif @JmillsExpensify @dubielzyk-expensify

1. #78316: What is the expected behavior here? In my opinion, pressing back on the confirm page should dismiss the modal since it's the first page the user sees when opening the approval workflow. If they navigate back to this page at any point and press back again, dismissing the modal seems like the logical behavior. However, this feels a bit confusing to me — what do you think?

2. #78342: We didn't discuss the expected behavior for this scenario. When a member who is configured as an additional approver in a workflow is removed from the workspace, should we reset the limit configuration (i.e., clear both the additional approver and the limit)? I assume yes, but if we go this route, we'll need backend changes as well. Currently, when the app goes online, the configuration is restored from the API and isn't removed:

https://github.com/user-attachments/assets/ec319b61-c551-4a38-a7d4-b95936c08f23

3. #78328: Is this a valid bug? In this case, there's another text element that has replaced the description. What should the page display here — should we show both texts? If so, how should they be laid out?

4. #78341: this was not in the requriement, just confirming should we tackle it now or keep it for a followup improvement?

[dubielzyk-expensify]

1. https://github.com/Expensify/App/issues/78316: What is the expected behavior here? In my opinion, pressing back on the confirm page should dismiss the modal since it's the first page the user sees when opening the approval workflow. If they navigate back to this page at any point and press back again, dismissing the modal seems like the logical behavior. However, this feels a bit confusing to me — what do you think?

I agree with your opinion here that it should close the modal since it's the first page. When seeing the video it felt very loopy and I wasn't expecting the behavior so I'd say close the modal there.

2. https://github.com/Expensify/App/issues/78342: We didn't discuss the expected behavior for this scenario. When a member who is configured as an additional approver in a workflow is removed from the workspace, should we reset the limit configuration (i.e., clear both the additional approver and the limit)? I assume yes, but if we go this route, we'll need backend changes as well. Currently, when the app goes online, the configuration is restored from the API and isn't removed:

I'll let @trjExpensify or @JmillsExpensify chime in here since I only have a vague memory about what we do. It make sense to me to clear the approver and the limit when they're removed from the workspace.

3. https://github.com/Expensify/App/issues/78328: Is this a valid bug? In this case, there's another text element that has replaced the description. What should the page display here — should we show both texts? If so, how should they be laid out?

Hmm. Yeah we technically need two descriptions here right? Can we just add them together? It might look a bit long but it should be 3 sentences instead of 2.

4. https://github.com/Expensify/App/issues/78341: this was not in the requriement, just confirming should we tackle it now or keep it for a followup improvement?

Also a question from @JmillsExpensify