[$250] [Due for payment 2025-12-23] Expense - More menu does not close after duplicating expense
If you havenβt already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.2.75-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://github.com/Expensify/App/pull/75323 Email or phone of affected tester (no customers): [email protected] Issue reported by: Applause Internal Team Bug source: Pull Request QA execution Device used: Mac 26.1 / Chrome App Component: Money Requests
Action Performed:
- Go to staging.new.expensify.com
- Go to workspace chat that has no unsettled expense.
- Create an expense.
- Open the report.
- Click More > Duplicate.
Expected Result:
More menu will close after duplicating expense.
Actual Result:
More menu does not close after duplicating expense. Report layout becomes highlighted.
Workaround:
Unknown
Platforms:
- [ ] Android: App
- [ ] Android: mWeb Chrome
- [ ] iOS: App
- [ ] iOS: mWeb Safari
- [ ] iOS: mWeb Chrome
- [x] Windows: Chrome
- [ ] MacOS: Chrome / Safari
- [ ] MacOS: Desktop
Screenshots/Videos
https://github.com/user-attachments/assets/b39973ca-6b36-45a0-a368-802ed14340fc
Issue Owner
Current Issue Owner: @Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~022003949793929414784
- Upwork Job ID: 2003949793929414784
- Last Price Increase: 2025-12-24
Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
Triggered auto assignment to @marcochavezf (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.
:wave: Friendly reminder that deploy blockers are time-sensitive β± issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
π¬ A slack conversation has been started in #expensify-open-source
This is coming from https://github.com/Expensify/App/pull/75323, I raised a fix for this bug by only reverting the throttle function https://github.com/Expensify/App/pull/77307 In that way, we keep the changes of the other PR, and we fix the bug before it goes to production cc @jjcoffee @JS00001 @hoangzinh
I think it's an expectation, not a bug. According to the description in this issue https://github.com/Expensify/App/issues/65948
Hold on, this issue https://github.com/Expensify/App/issues/65948 doesn't clearly state whether the menu should hide or remain visible after the animation.
Yes this is expected, at least based on my interpretation of the visuals in the issue. I think it would be weird if it auto-closes after the animation runs. cc @dubielzyk-expensify @garrettmknight in case I misunderstood!
We should do what we do with copy message which is to close it, but after a delay:
https://github.com/user-attachments/assets/e99e5833-3ea0-423a-9c7f-02ccc7005c6e
So let's reuse the same code and logic (he says not being an engineer π ). cc @Expensify/design for visibility
@dubielzyk-expensify So just to confirm, should we still move between Duplicate->Duplicated->Duplicate and then close, or just close after showing Duplicated (with some delay).
Hmm. Sorry I now see what's going on. It's going from one-expense report to report so the duplicate option isn't available on that view. In that instance I think we can just immediately close the dialog when they click Duplicate cause the option won't be there. This is quite awkward and maybe @Expensify/product or @Expensify/design has other ideas. We should still retain the duplicate -> duplicated -> close dialog behavior where the option is still available
Haha, oh I actually didn't check the video π I'll get a fix for this issue in https://github.com/Expensify/App/pull/77343, so that for a single transaction report we always immediately close the modal. It will look like this:
https://github.com/user-attachments/assets/fd832069-3656-4df9-9212-dfc9fafe3c10
We should still retain the duplicate -> duplicated -> close dialog behavior where the option is still available
I guess this could be handled in a follow-up? It feels like something that we'll need some back and forth on.
Another option is we temporarily hide the "Duplicate" menu option, then address DBs and show it again if your PR https://github.com/Expensify/App/pull/77343 is not ready @jjcoffee
I think for consistency we should still just have the menu item change to "duplicated" and then close the popover, but I agree it's polish and the blocker to clear here is the menu remaining open.
@trjExpensify Do you think this will do for now then?
Yeah, if we have that ready to go to clear the blocker, I think that's fine. π
Agree with Tom (and Jon) above π
Issue is not repro on Mac Chrome, build 9.2.75-1. The feature is disabled
https://github.com/user-attachments/assets/e853a064-e750-4e0d-9658-004df26dfea0
Thanks! Demoting this one now since we disabled the feature
Since we disabled the feature for now, I guess the question is should we still go ahead with this option for now? I think this makes the most sense, as we'll be able to re-enable the feature faster, then we can refine it in a follow-up. cc @trjExpensify @Expensify/design
I belive that is what @trjExpensify meant above, but he can probably give a better answer
Yep!
Reviewing label has been removed, please complete the "BugZero Checklist".
The solution for this issue has been :rocket: deployed to production :rocket: in version 9.2.78-8 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:
- https://github.com/Expensify/App/pull/77421
If no regressions arise, payment will be issued on 2025-12-23. :confetti_ball:
For reference, here are some details about the assignees on this issue:
- @jjcoffee requires payment through NewDot Manual Requests
@jjcoffee @twisterdotcom The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Heads up assignees, I will be OOO for the last two weeks of Dec. If you need this $250 (is it $250 @JS00001?) then please bump the other assignees here to get another BZ employee on it. Otherwise, I'll get this sorted for you in early Jan.
I have reviewed the fix here. @JS00001 can u assign me here for the payment process? Thx
β οΈ Looks like this issue was linked to a Deploy Blocker here
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
Payment Summary
Upwork Job
- Reviewer: @jjcoffee owed $250 via NewDot
- ROLE: @FitseTLT paid $(AMOUNT) via Upwork (LINK)
BugZero Checklist (@twisterdotcom)
- [ ] (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
- [ ] I have verified the correct assignees and roles are listed above and updated the necessary manual offers
- [ ] I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
- [ ] I have verified the PR was not reverted
- [ ] I have applied any discounts due to bugs/regressions introduced by this PR
- [ ] I have paid out the Upwork contracts or cancelled the ones that are incorrect
- [ ] I have verified the payment summary above is correct
@FitseTLT @hoangzinh and/or @jjcoffee can you breakdown who is owed what? Lotta action and linked issues in the PR
- https://github.com/Expensify/App/pull/77343
Unsure if this is from a regression either.