[$250] Auto-pay -"Changed the approver to [User]" system message appears before auto-pay
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.2.74-2 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://github.com/Expensify/App/pull/76302 Issue reported by: Applause - Internal Team
Action Performed:
- Sign in to ND with a new gmail account
- Create a workspace, enable Rules
- Open Rules page, enable "Auto-approve compliant reports under", do not change the data (the limit is set to $100 by default)
- Go to Workflows - Payments section, add Regions 1111 bank account
- Open Rules page, enable "Auto-pay approved reports", do not change the data (the limit is set to $100 by default)
- Navigate to the workspace chat, create two expenses
- Open expense report, click Submit
Expected Result:
"Changed the approver to @[logged in user's email address]" system message does not appear before starting payment message
Actual Result:
"Changed the approver to @[logged in user's email address]" system message appears before starting payment message
Workaround:
Unknown
Platforms:
Select the officially supported platforms where the issue was reproduced:
- [ ] Android: App
- [ ] Android: mWeb Chrome
- [ ] iOS: App
- [ ] iOS: mWeb Safari
- [ ] iOS: mWeb Chrome
- [x] Windows: Chrome
- [ ] MacOS: Chrome / Safari
- [ ] MacOS: Desktop
Platforms Tested:
On which of our officially supported platforms was this issue tested:- [ ] Android: App
- [ ] Android: mWeb Chrome
- [ ] iOS: App
- [ ] iOS: mWeb Safari
- [ ] iOS: mWeb Chrome
- [ ] Windows: Chrome
- [ ] MacOS: Chrome / Safari
- [ ] MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/user-attachments/assets/317ba2cd-9ce2-49ca-b57d-7b028f67ef18
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021998945040352239085
- Upwork Job ID: 1998945040352239085
- Last Price Increase: 2025-12-25
Issue Owner
Current Issue Owner: @mananjadhav
Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
This looks more backend to me , backend shouldn't create a TAKE_CONTROL/REROUTE action when the approver change is implicit during auto-pay flow
For front it should filter out these actions when they occur immediately before an auto-pay action
| File | Role |
|---|---|
src/libs/ReportUtils.ts |
Contains buildOptimisticChangeApproverReportAction() that creates TAKE_CONTROL/REROUTE actions |
src/libs/actions/IOU.ts |
Contains submitReport(), approveMoneyRequest(), and assignReportToMe() functions |
src/libs/ReportActionsUtils.ts |
Contains getChangedApproverActionMessage() that generates the "changed the approver" message |
src/languages/en.ts |
Contains the translation key iou.changeApprover.changedApproverMessage |
Backend API (SubmitReport) |
Handles the submission, auto-approve, and auto-pay flow |
Job added to Upwork: https://www.upwork.com/jobs/~021998945040352239085
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)
@mananjadhav can you confirm the comment here?
Just a heads up that am heading OoO until Dec. 17. I will address this as soon as I am back, but if something is needed in the meantime, please reach out in Slack. Thanks!
I'll review this by tomorrow.
Hey @mananjadhav — any update on the review?
@mananjadhav Whoops! This issue is 2 days overdue. Let's get this updated quick!
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
@mananjadhav if you need more context about my assessment let me know
@CortneyOfstad , Could you please invite me to slack using my registered contributor email when you have few seconds that'll be awesome , thanks
@mavrickdeveloper please fill out the form here We've been having multiple issues with invites so please keep filling it out every week or two til you're invited. Thx
@mananjadhav Huh... This is 4 days overdue. Who can take care of this?
I'll take a look tomorrow.
@mananjadhav @CortneyOfstad this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
@mananjadhav Whoops! This issue is 2 days overdue. Let's get this updated quick!
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
@mananjadhav Huh... This is 4 days overdue. Who can take care of this?
@mananjadhav – any update on the comment here?
I checked this. This needs to be fixed from the BE. @CortneyOfstad Can we assign internal label here?
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
Issue not reproducible during KI retests. (First week)
@mananjadhav Huh... This is 4 days overdue. Who can take care of this?
@mananjadhav @CortneyOfstad this issue is now 4 weeks old, please consider:
- Finding a contributor to fix the bug
- Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
- If you have any questions, don't hesitate to start a discussion in #expensify-open-source
Thanks!