App icon indicating copy to clipboard operation
App copied to clipboard

[$250] Expense - Tag field is not replaced with Project when connecting to Intacct and Remains on Expense.

Open vincdargento opened this issue 1 month ago • 18 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: V9.2.66-3 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/search?q=3741 Email or phone of affected tester (no customers): [email protected] Issue reported by: Applause Internal Team Device used: Redminote 10S Android 13 App Component: Money Requests

Action Performed:

  1. Launch app
  2. Create a workspace
  3. Enable accounting and connect to sage intact
  4. Create another workspace
  5. Enable tags and add a tag
  6. Open workspace chat
  7. Create an expense with tag
  8. Go to workspace settings - enable accounting
  9. Connect to existing sage intact connection
  10. Open workspace chat
  11. Open the expense details

Expected Result:

Tag field is removed, and replaced with Projects. The selected tag is listed as an out of workspace Project

Actual Result:

The expense contains both a Project field and Tag field, which is incorrect. More detail in comment here

Workaround:

Unknown

Platforms:

  • [x] Android: App
  • [x] Android: mWeb Chrome
  • [ ] iOS: App
  • [ ] iOS: mWeb Safari
  • [ ] iOS: mWeb Chrome
  • [x] Windows: Chrome
  • [ ] MacOS: Chrome / Safari
  • [ ] MacOS: Desktop

Screenshots/Videos

Image

https://github.com/user-attachments/assets/4b40c0c7-a014-43de-b2fc-c597641bf0f6

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021997850488460226735
  • Upwork Job ID: 1997850488460226735
  • Last Price Increase: 2025-12-15
Issue OwnerCurrent Issue Owner: @eVoloshchak

vincdargento avatar Dec 01 '25 19:12 vincdargento

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] avatar Dec 01 '25 19:12 melvin-bot[bot]

So there is an issue here, but the Expected Result is a bit off. When connecting to Sage Intacct (or any other accounting integration) we should remove the Tag line, as it would be replaced by Classes, Customers, Projects, Departments, Locations, etc (whatever the customer decides to import in from Sage Intacct). The default "tag" option should not be listed, and instead be replaced by one of those options as it is a requirement that when you connect to an accounting integration – categories and tags are imported into Expensify from that accounting integration.

So, the idea of the incorrect tag, "Fer" being listed as an incorrect Project is fine, but the Tag field on the expense needs to be removed.

Does that make sense @vincdargento? I wanted to make sure that we clear before I edited the main comment on the GH

Image

CortneyOfstad avatar Dec 04 '25 14:12 CortneyOfstad

Job added to Upwork: https://www.upwork.com/jobs/~021997850488460226735

melvin-bot[bot] avatar Dec 08 '25 02:12 melvin-bot[bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

melvin-bot[bot] avatar Dec 08 '25 02:12 melvin-bot[bot]

Updating the original GH message

CortneyOfstad avatar Dec 08 '25 02:12 CortneyOfstad

@eVoloshchak — I wonder if that change would potentially require a BE change due to the nature of the fields. Interested to hear your thoughts as I am not 100% sure on whether a BE or FE fix would be best.

CortneyOfstad avatar Dec 09 '25 19:12 CortneyOfstad

Hey team! I am heading OoO until Dec. 17. If you need anything from a BZ perspective, please reach out in Slack, otherwise I will get it sorted as soon as I am back! Thanks!

CortneyOfstad avatar Dec 11 '25 02:12 CortneyOfstad

@eVoloshchak Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] avatar Dec 12 '25 00:12 melvin-bot[bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] avatar Dec 15 '25 16:12 melvin-bot[bot]

@eVoloshchak @CortneyOfstad this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] avatar Dec 15 '25 21:12 melvin-bot[bot]

@eVoloshchak 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

melvin-bot[bot] avatar Dec 16 '25 00:12 melvin-bot[bot]

I wonder if that change would potentially require a BE change due to the nature of the fields.

@CortneyOfstad, this will require a BE fix. Not fully sure whether an FE one will be needed (but most probably yes, I wonder if external contributors can connect to sage intact)

eVoloshchak avatar Dec 16 '25 19:12 eVoloshchak

Still a hotpick!

CortneyOfstad avatar Dec 19 '25 15:12 CortneyOfstad

@eVoloshchak Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] avatar Dec 20 '25 00:12 melvin-bot[bot]

Still a hotpick!

CortneyOfstad avatar Dec 22 '25 16:12 CortneyOfstad

@eVoloshchak 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

melvin-bot[bot] avatar Dec 23 '25 23:12 melvin-bot[bot]

Same as above

eVoloshchak avatar Dec 25 '25 11:12 eVoloshchak

I think this is the expected behavior.

  • https://github.com/Expensify/Expensify/issues/71274
  • https://github.com/Expensify/Integration-Server/pull/4422
  • https://github.com/Expensify/Integration-Server/blob/e6a06fcdfaf3768c0a9170c9bff3b46d766be910/src/expensify/policy/PolicyUtils.java#L226

cc @nkuoch @francoisl

s77rt avatar Dec 25 '25 19:12 s77rt

@francoisl can you confirm if the workspace tag should still be listed when connected to an accounting integration? I was under the impression that:

If employee selects a workspace tag ("Entertainment") on an expense and later connects to an accounting integration ("QBO") and selects the option to import Classes as tags, the Tag field should be renamed to Classes but still show the original workspace selection ("Entertainment") but list it as a violation.

Is that logic not the case anymore? Here is my original comment showing an example: https://github.com/Expensify/App/issues/76448#issuecomment-3612406594

CortneyOfstad avatar Dec 29 '25 16:12 CortneyOfstad

After reading https://github.com/Expensify/Expensify/issues/57982 and https://github.com/Expensify/Expensify/issues/71274, it seems like the current behavior is correct. When you connect to an accounting solution, we need to keep your existing tag lists, and prepend the integration tag lists into your policy.

It sounds like we can close this issue, but we might also need to update the test case linked in the OP so it's not considered a bug again in the future.

francoisl avatar Dec 29 '25 23:12 francoisl

@eVoloshchak Still overdue 6 days?! Let's take care of this!

melvin-bot[bot] avatar Jan 01 '26 23:01 melvin-bot[bot]