Change option row and push inputs chevrons to new look

[daledah]

Explanation of Change

Change option row and push inputs chevrons to new look

Fixed Issues

$ https://github.com/Expensify/App/issues/76266 PROPOSAL: https://github.com/Expensify/App/issues/76266#issuecomment-3587827265

Tests

For all pushrows and options rows verify that:

• Icon has size 16px

• Icon goes from 100% opacity to 50% opacity

• Icon should be 100% opacity on hover

• [x] Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

• [x] Verify that no errors appear in the JS console

PR Author Checklist

• [x] I linked the correct issue in the ### Fixed Issues section above
• [x] I wrote clear testing steps that cover the changes made in this PR
  • [x] I added steps for local testing in the Tests section
  • [x] I added steps for the expected offline behavior in the Offline steps section
  • [x] I added steps for Staging and/or Production testing in the QA steps section
  • [x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • [x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • [x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• [x] I included screenshots or videos for tests on all platforms
• [x] I ran the tests on all platforms & verified they passed on:
  • [x] Android: Native
  • [x] Android: mWeb Chrome
  • [x] iOS: Native
  • [x] iOS: mWeb Safari
  • [x] MacOS: Chrome / Safari
• [x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• [x] I verified there are no new alerts related to the canBeMissing param for useOnyx
• [x] I followed proper code patterns (see Reviewing the code)
  • [x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • [x] I verified that comments were added to code that is not self explanatory
  • [x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • [x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • [x] If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • [x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • [x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • [x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • [x] I verified the JSDocs style guidelines (in STYLE.md) were followed
• [x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• [x] I followed the guidelines as stated in the Review Guidelines
• [x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• [x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• [x] I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• [x] I verified that if a function's arguments changed that all usages have also been updated correctly
• [x] If any new file was added I verified that:
  • [x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• [x] If a new CSS style is added I verified that:
  • [x] A similar style doesn't already exist
  • [x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• [x] If new assets were added or existing ones were modified, I verified that:
  • [x] The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • [x] The assets load correctly across all supported platforms.
• [x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• [x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• [x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• [x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• [x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • [x] I verified that all the inputs inside a form are aligned with each other.
  • [x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• [x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• [x] I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• [x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/f6838bb9-d7a1-4dac-a529-1ae8e2908967

Android: mWeb Chrome

https://github.com/user-attachments/assets/58606278-0fb4-4224-91dc-580d9cb04a4a

iOS: Native

https://github.com/user-attachments/assets/d2a99a3a-f010-458e-aab9-a560c2069d9c

iOS: mWeb Safari

https://github.com/user-attachments/assets/ec5f526b-e743-43b0-89d5-23bcd7ae1612

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/c44d7089-0216-4181-b76a-78d0dbc34727

[melvin-bot[bot]]

@dominictb Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[daledah]

I'm having a trouble when running the Android simulator, will add videos later

[codecov[bot]]

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/components/MenuItem.tsx	86.38% <100.00%> (-0.22%)	:arrow_down:
... and 8 files with indirect coverage changes

[dominictb]

@inimaga Can you run test build here so @dubielzyk-expensify could take a look?

[github-actions[bot]]

🚧 @dubielzyk-expensify has triggered a test Expensify/App build. You can view the workflow run here.

[github-actions[bot]]

:test_tube::test_tube: Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! :test_tube::test_tube: Built from App PR Expensify/App#76292.

Android :robot:	iOS :apple:
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/76292/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/76292/index.html

Web :spider_web:
https://76292.pr-testing.expensify.com

---

:eyes: View the workflow run that generated this build :eyes:

[dubielzyk-expensify]

It's looking pretty great. I'd be keen to hear @dannymcclain 's feedback. One potential is to make it opacity 0.7 instead of 0.5. That gives the three dots also a bit more clarity and given how many push rows we have it might make it a bit clearer. I prefer 0.5 on the chevron itself though, but maybe not on the three dots.

50% opacity

70% opacity

Whatever we use we should use everywhere. I guess we don't have many three dots so maybe we shouldn't optimize for it. Curious to hear what you think, Danny.

[dubielzyk-expensify]

Even this looks so much better already:

[dannymcclain]

Yeah I see what you're saying, but I think I'm in the camp of "let's not optimize for the three-dots". Especially as we're actively moving away from them in so many places. I think I'd prefer to stick with 50% opacity because we have SO many carets in the product, I'd prefer to optimize for those.

[dubielzyk-expensify]

Yeah that makes a lot of sense. Can you run through the test build and give your feedback. Otherwise I think we're good 👍

[dannymcclain]

Loving this so far!

It seems like some of the rows have a bit too much space on the right? (This screenshot is for desktop, which is why my squares are 32x32 - on mobile they'd be 20x20)

Same goes for here - the right spacing looks much bigger to me:

Also, I think the plan was to have these just go to full opacity on hover instead of changing color completely.

[dubielzyk-expensify]

Also, I think the plan was to have these just go to full opacity on hover instead of changing color completely.

There's areas where we change them to text. I like your suggestion better, but we're a bit inconsistent in the app cause they don't change on Reports -> Expenses, but do on Reports -> Reports

[dubielzyk-expensify]

It seems like some of the rows have a bit too much space on the right? (This screenshot is for desktop, which is why my squares are 32x32 - on mobile they'd be 20x20)

Yeah I like the idea of putting the chevron closer to the edge of the padding as well. That'd be great!

[dannymcclain]

There's areas where we change them to text.

Yeah you're right, but I thought the plan was to update them all to have the new styling. I don't see why we'd have 2 different hover styles for these honestly.

I like your suggestion better, but we're a bit inconsistent in the app cause they don't change on Reports -> Expenses, but do on Reports -> Reports

😫 They DO change on Reports > Expenses, but you have to hover over the actual arrow. They were implemented improperly. They should ALL work like Reports > Reports IMO.

[dubielzyk-expensify]

Yeah you're right, but I thought the plan was to update them all to have the new styling. I don't see why we'd have 2 different hover styles for these honestly.

Agree. Happy to go with that.

😫 They DO change on Reports > Expenses, but you have to hover over the actual arrow. They were implemented improperly. They should ALL work like Reports > Reports IMO.

Agree. Let's do it.

[dominictb]

@daledah Do you need to update the PR based on above feedbacks?

[daledah]

Yeah I like the idea of putting the chevron closer to the edge of the padding as well. That'd be great!

@dubielzyk-expensify @dannymcclain is this expected?

[dubielzyk-expensify]

That looks great to my eyes. Keen to hear what @dannymcclain

[dannymcclain]

Yup that looks much better. Thanks!

[daledah]

@dominictb i updated, please check again

[dominictb]

They DO change on Reports > Expenses, but you have to hover over the actual arrow. They were implemented improperly. They should ALL work like Reports > Reports IMO.

Are we handling this somewhere else or should we fix it in this PR?

Also about the caret color on hover, does this look right?

Or do we want it to behave like this row in Reports tab?

@dubielzyk-expensify Feel free to run another test build if you want. Code already looks fine to me.

[dannymcclain]

Are we handling this somewhere else or should we fix it in this PR?

We don't need to fix it here. @dubielzyk-expensify reported it and we have an issue to fix it: https://github.com/Expensify/App/issues/76752

Also about the caret color on hover, does this look right? Or do we want it to behave like this row in Reports tab?

We want it to behave like the rows on the Reports tab. So the carets should be our icons color at 50% opacity and hover to 100% opacity with no color change.

[dominictb]

We want it to behave like the rows on the Reports tab. So the carets should be our icons color at 50% opacity and hover to 100% opacity with no color change.

cc @daledah

[dubielzyk-expensify]

Spot on, Danny 👍

[daledah]

@dominictb i updated

https://github.com/user-attachments/assets/16a4a674-43e1-4565-adc2-004ac8da9a5f

[dominictb]

BUG

Chevron is too close to the right in workspace chat navigator button.

Prod	PR

[dominictb]

@Expensify/design Here's what it looks with the opacity change. Feel free to run another test build.

[dominictb]

Reviewer Checklist

• [x] I have verified the author checklist is complete (all boxes are checked off).
• [x] I verified the correct issue is linked in the ### Fixed Issues section above
• [x] I verified testing steps are clear and they cover the changes made in this PR
  • [x] I verified the steps for local testing are in the Tests section
  • [x] I verified the steps for Staging and/or Production testing are in the QA steps section
  • [x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • [x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• [x] I checked that screenshots or videos are included for tests on all platforms
• [x] I included screenshots or videos for tests on all platforms
• [x] I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• [x] I verified tests pass on all platforms & I tested again on:
  • [x] Android: HybridApp
  • [x] Android: mWeb Chrome
  • [x] iOS: HybridApp
  • [x] iOS: mWeb Safari
  • [x] MacOS: Chrome / Safari
• [x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• [x] I verified there are no new alerts related to the canBeMissing param for useOnyx
• [x] I verified proper code patterns were followed (see Reviewing the code)
  • [x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • [x] I verified that comments were added to code that is not self explanatory
  • [x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • [x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • [x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • [x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • [x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • [x] I verified the JSDocs style guidelines (in STYLE.md) were followed
• [x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• [x] I verified that this PR follows the guidelines as stated in the Review Guidelines
• [x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• [x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• [x] I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• [x] If a new component is created I verified that:
  • [x] A similar component doesn't exist in the codebase
  • [x] All props are defined accurately and each prop has a /** comment above it */
  • [x] The file is named correctly
  • [x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • [x] The only data being stored in the state is data necessary for rendering and nothing else
  • [x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • [x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • [x] All JSX used for rendering exists in the render method
  • [x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• [x] If any new file was added I verified that:
  • [x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• [x] If a new CSS style is added I verified that:
  • [x] A similar style doesn't already exist
  • [x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• [x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• [x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• [x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• [x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• [x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • [x] I verified that all the inputs inside a form are aligned with each other.
  • [x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• [x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• [x] For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• [x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• [ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

[dominictb]

BUG

Press and hold push row does not update chevron opacity:

Prod	PR

[daledah]

Press and hold push row does not update chevron opacity:

On production, it doesn’t change the opacity on hover; instead, it changes the color of the icon. @Expensify/design should we fix this bug?