[$250] Update option missing for Personal Bank Accounts in ND compared to Classic

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.2.63-5 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @ade-constantiniu Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

Precondition : User connected a personal bank account to the wallet

1. Navigate to Account > Wallet in ND
2. Switch to OD and Navigate to Wallet in Account
3. Observe the added personal bank account

Expected Result:

Update option displayed in both ND and Classic

Actual Result:

Update option only displayed in Classic and not in ND

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• [ ] Android: App
• [ ] Android: mWeb Chrome
• [ ] iOS: App
• [ ] iOS: mWeb Safari
• [ ] iOS: mWeb Chrome
• [x] Windows: Chrome
• [x] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• [ ] Android: App
• [ ] Android: mWeb Chrome
• [ ] iOS: App
• [ ] iOS: mWeb Safari
• [ ] iOS: mWeb Chrome
• [x] Windows: Chrome
• [ ] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/d35dcfcf-1c05-4d91-93a9-1a6845743e7e

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021993853402714004839
• Upwork Job ID: 1993853402714004839
• Last Price Increase: 2025-12-25

Issue Owner

Current Issue Owner: @dukenv0307

[melvin-bot[bot]]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~021993853402714004839

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

[paulnjs]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Update option only displayed in Classic and not in ND

What is the root cause of that problem?

We do not have the logic to display the update option for personal bank account like OD

What changes do you think we should make in order to solve the problem?

Show the update option

Add update option in

https://github.com/Expensify/App/blob/8f6de1c00a40e1004ae52585abafef6cd04d7fbd/src/pages/settings/Wallet/WalletPage/WalletPage.tsx#L626

{paymentMethod.selectedPaymentMethodType === CONST.PAYMENT_METHODS.PERSONAL_BANK_ACCOUNT &&
                            paymentMethod.selectedPaymentMethod?.type === CONST.BANK_ACCOUNT.TYPE.PERSONAL && (
                                <MenuItem
                                    title={translate('bankAccount.updateDetails')}
                                    icon={Expensicons.Pencil}
                                    onPress={() => {
                                        // Navigate to update bank account page
                                    }}
                                    wrapperStyle={[styles.pv3, styles.ph5, !shouldUseNarrowLayout ? styles.sidebarPopover : {}]}
                                />
                            )}

Create the page for updating bank account. In this page we can update

Name on Bank Account Address on Bank Account (PO Boxes not allowed) Phone Number

Same as OD

We also need BE API to do that

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[dukenv0307]

@Expensify/design Here's the UI in OD when updating the personal bank account

Do we have the design for this page in ND?

[dubielzyk-expensify]

cc @joekaufmanexpensify on this one to let me know what the right move is

[melvin-bot[bot]]

@dukenv0307 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[dukenv0307]

Still waiting for @joekaufmanexpensify

[joekaufmanexpensify]

We only show the Update button for personal bank accounts in OldDot if they are missing any of name, address, or phone number. We already collect those for new US accounts in OldDot. We're going to soon collect them for new US accounts in NewDot once https://github.com/Expensify/App/issues/73693 is done.

So, the only consideration here is whether we want to add an error somewhere in NewDot for someone with an existing US personal bank account that is missing any of this information. Probably not a bad idea to. We could add an error that points the user to profile > personal details to fill this out there. Or maybe add an RBR on a personal bank account with an Update button that prompts them for name, address, phone number. I'd be fine with either personally.

[dukenv0307]

Thank you @joekaufmanexpensify. @paulnjs do you want to update your proposal?

[dukenv0307]

@joekaufmanexpensify Just want to confirm if we found any information about name, address, phone number missing from the profile page

We'll show the update button and RBR for the personal bank account in Wallet page. Is it correct?

[joekaufmanexpensify]

We still need to decide. I'd be curious what @Expensify/design thinks about this. It will be an edge case going forward once https://github.com/Expensify/App/issues/73693 is done, but some existing customers who have added US personal bank accounts in NewDot could be impacted by this. It's not common because the lack of personal info on file only causes global reimbursement payments to US personal bank accounts to fail. IE, if someone makes a USD > USD reimbursement, it's fine. But a GBP > USD reimbursement will fail if this info isn't on file. So feels worth solving to me.

As for the solution, I feel like an RBR to the bank account on Wallet with an Update button to collect the personal info might be simplest. It could be a bit funky if someone has multiple personal bank accounts in this state, but I doubt that will be common. Thoughts?

[dannymcclain]

I don't think I feel passionately for one option vs. the other, but I think I might lean ever so slightly towards your idea of the RBR on the personal bank account with an Update button that prompts them for name, address, phone number. That feels pretty simple to me too. (And I do agree it's probably worth doing something here even though this seems to be a pretty uncommon occurrence.)

[dukenv0307]

@joekaufmanexpensify

I might lean ever so slightly towards your idea of the RBR on the personal bank account with an Update button that prompts them for name, address, phone number

If so, can you confirm this flow?

[dubielzyk-expensify]

Agree with you on that one Danny

[joekaufmanexpensify]

@joekaufmanexpensify Just want to confirm if we found any information about name, address, phone number missing from the profile page

@dukenv0307 we only collect name, address, and phone number with US personal bank accounts in OldDot today. So we'd only need to collect those here, not DOB. In terms of the flow, I would personally expect:

• A GBR on Account > Wallet > the bank account row, leading you to the bank account requiring update. Maybe we could use our existing Action required badge from partially setup business bank accounts and just make the whole row tappable, rather than use an update button?
• Opening the bank account requiring update would prompt for whatever is missing out of name, address, and phone number. We could probably just reuse the existing pages to collect these + confirmation page we're adding in https://github.com/Expensify/App/issues/73693.
• If you have multiple personal bank accounts requiring update, I expect completing the flow for one would save the info to all of the bank accounts.

[joekaufmanexpensify]

This is really a new feature, rather than a bug, so going to swap the labels here so someone from the design team can help with the mocks

[melvin-bot[bot]]

Current assignee @sakluger is eligible for the NewFeature assigner, not assigning anyone new.

[melvin-bot[bot]]

Triggered auto assignment to Design team member for new feature review - @dubielzyk-expensify (NewFeature)

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[sakluger]

@dubielzyk-expensify do you need any more info before putting together mockups for this feature?

[dubielzyk-expensify]

Sorry, I missed this. What mocks are needed here?

[sakluger]

I'm not entirely sure ha. I was going off Joe's comment here: https://github.com/Expensify/App/issues/76053#issuecomment-3606841795

[dubielzyk-expensify]

@joekaufmanexpensify what mocks do you need for this?

[joekaufmanexpensify]

We need to handle this case. I outlined my thoughts on the flow here. If you agree, could you help mock the flow?

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[dukenv0307]

@dubielzyk-expensify can you please take a look at the comment above? Thanks

[dubielzyk-expensify]

I'll make some mocks 👍

[dubielzyk-expensify]

How does this look to you, @joekaufmanexpensify ?

Changing words like adding/add to updating/update. Think it's also worth having an end success state. cc @Expensify/design for vis

[dannymcclain]

I dig the confirmation as well. One little type on the address screen: What are your address? should be What is your address?