App icon indicating copy to clipboard operation
App copied to clipboard

[$250] [Due for payment 2025-12-19] [Splits in NewDot] Add Split to the select menu when 1 expense is selected, editable and not the child of an existing Split expense

Open garrettmknight opened this issue 2 months ago β€’ 28 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: N/A Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @coleaeason / @trjExpensify Slack conversation (hyperlinked to channel name): migrate

Action Performed:

  1. Create an expense
  2. Select the checkbox next to the expense (this should work the same in the report view and the Reports page view)
  3. Click 1 selected

Expected Result:

Since you can split in the More menu of an editable, non-split transaction, you should see it in the 1 selected menu as well. There are a few additional pieces of context here:

  • Submitters and assigned approvers can split expenses that they can edit.
  • Admins can split expenses on Draft and Processing reports.
  • Non-editable expenses include pending Expensify Card expenses and Expensiworks expenses for all users.
  • Users should not see the Split option in the 1 selected menu for portions of expenses that have already been split.

Actual Result:

Split isn't an option in the 1 selected menu.

Workaround:

Users can still open the expense via RHP and split.

Platforms:

Select the officially supported platforms where the issue was reproduced: ALL

Platforms Tested: On which of our officially supported platforms was this issue tested:
  • [ ] Android: App
  • [ ] Android: mWeb Chrome
  • [ ] iOS: App
  • [ ] iOS: mWeb Safari
  • [ ] iOS: mWeb Chrome
  • [ ] Windows: Chrome
  • [ ] MacOS: Chrome / Safari
  • [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~022003945749544060829
  • Upwork Job ID: 2003945749544060829
  • Last Price Increase: 2025-12-24

garrettmknight avatar Oct 28 '25 16:10 garrettmknight

Triggered auto assignment to @muttmuure (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO. Remember to draft any necessary HelpDot updates by following the instructions here.

melvin-bot[bot] avatar Oct 28 '25 16:10 melvin-bot[bot]

:warning: It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time :warning:

melvin-bot[bot] avatar Oct 28 '25 16:10 melvin-bot[bot]

Triggered auto assignment to Design team member for new feature review - @dubielzyk-expensify (NewFeature)

melvin-bot[bot] avatar Oct 28 '25 16:10 melvin-bot[bot]

@dubielzyk-expensify I think this one is pretty simple. Fig here, but: Reports page:

Image

Report view:

Image

garrettmknight avatar Oct 28 '25 19:10 garrettmknight

What do you need here sorry? πŸ˜…

The green button should say 1 selected btw

dubielzyk-expensify avatar Oct 29 '25 09:10 dubielzyk-expensify

@garrettmknight About Reports page Do we really need to add Split here? Since we don't have Merge in this menu also

https://github.com/user-attachments/assets/0bc57414-b7da-4fbd-9c01-ad39d2941aba

ZhenjaHorbach avatar Oct 30 '25 13:10 ZhenjaHorbach

yep, we do.. Merge is in the process of being added by @youssef-lr I believe.

trjExpensify avatar Oct 30 '25 13:10 trjExpensify

And I suppose in the future we will need to fix the order of the elements πŸ˜…

Image Image

ZhenjaHorbach avatar Oct 30 '25 13:10 ZhenjaHorbach

This issue has not been updated in over 15 days. @muttmuure, @ZhenjaHorbach, @eh2077, @dubielzyk-expensify eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

melvin-bot[bot] avatar Dec 05 '25 00:12 melvin-bot[bot]

Triggered auto assignment to @Julesssss, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

melvin-bot[bot] avatar Dec 09 '25 12:12 melvin-bot[bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] avatar Dec 12 '25 22:12 melvin-bot[bot]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.2.77-1 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

  • https://github.com/Expensify/App/pull/73855

If no regressions arise, payment will be issued on 2025-12-19. :confetti_ball:

For reference, here are some details about the assignees on this issue:

  • @ZhenjaHorbach requires payment through NewDot Manual Requests
  • @eh2077 requires payment through NewDot Manual Requests

melvin-bot[bot] avatar Dec 12 '25 22:12 melvin-bot[bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [ ] [@ZhenjaHorbach / @eh2077] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [ ] [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

melvin-bot[bot] avatar Dec 12 '25 22:12 melvin-bot[bot]

Issue is ready for payment but no BZ is assigned. @lydiabarclay you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

melvin-bot[bot] avatar Dec 19 '25 23:12 melvin-bot[bot]

Hi everyone! I'm not sure why I've been assigned as I can see @muttmuure is still assigned here. I'm happy to help if needed before I go OOO tomorrow 12/22 - 1/5, but a) I need to know what the bounty is and b) we need the BZ checklist filled out here.

lydiabarclay avatar Dec 20 '25 00:12 lydiabarclay

I am OOO starting 12/22/25 and will return 1/5/26. If this GH needs attention or action during that time, please re-apply the Bug label to assign someone to help out.

lydiabarclay avatar Dec 20 '25 04:12 lydiabarclay

@muttmuure Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] avatar Dec 23 '25 23:12 melvin-bot[bot]

Job added to Upwork: https://www.upwork.com/jobs/~022003945749544060829

melvin-bot[bot] avatar Dec 24 '25 21:12 melvin-bot[bot]

Current assignees @ZhenjaHorbach and @eh2077 are eligible for the External assigner, not assigning anyone new.

melvin-bot[bot] avatar Dec 24 '25 21:12 melvin-bot[bot]

Payment Summary

Contributor: @ZhenjaHorbach due $250 via NewDot Contributor+: @eh2077 due $250 via NewDot

@eh2077 plz complete the BZ checklist.

mallenexpensify avatar Dec 24 '25 21:12 mallenexpensify

Payment Summary

Contributor: @eh2077 due $250 via NewDot Contributor+: @ZhenjaHorbach due $250 via NewDot

@ZhenjaHorbach plz complete the BZ checklist.

@eh2077 is a reviewer here

ZhenjaHorbach avatar Dec 24 '25 21:12 ZhenjaHorbach

Thanks @ZhenjaHorbach , updated

@eh2077 plz complete the BZ checklist.

mallenexpensify avatar Dec 24 '25 22:12 mallenexpensify

Hello everyone, I got the issue from Upwork, checked the repo and the NewDot build, and concluded it can come from the usage of ReportSecondaryActionUtils that has isSplitAction() function

Unless I am wrong, this is where I believed to be the starting problem to trace the issue. As there are some if checks to be done there, I suspect to check it first there

So, if you don't mind:

  • I can check all of those if checks to make sure everything is working as intended
  • If that is not the real problem, I can trace to the usage of where isSplitAction() is used in the regarded context and implement fix
  • If everything that uses isSplitAction() traced and still has the same issue, I may discuss some potential solutions with the core team if needed

Corfliss avatar Dec 25 '25 15:12 Corfliss

πŸ“£ @Corfliss! πŸ“£ Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details. Screen Shot 2022-11-16 at 4 42 54 PM Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

melvin-bot[bot] avatar Dec 25 '25 15:12 melvin-bot[bot]

Contributor details Your Expensify account email: [email protected] Upwork Profile Link: https://www.upwork.com/freelancers/~0195762c2c093ab931

Corfliss avatar Dec 25 '25 15:12 Corfliss

βœ… Contributor details stored successfully. Thank you for contributing to Expensify!

melvin-bot[bot] avatar Dec 25 '25 15:12 melvin-bot[bot]

Hello everyone, I got the issue from Upwork, checked the repo and the NewDot build, and concluded it can come from the usage of ReportSecondaryActionUtils that has isSplitAction() function

Unless I am wrong, this is where I believed to be the starting problem to trace the issue. As there are some if checks to be done there, I suspect to check it first there

So, if you don't mind:

  • I can check all of those if checks to make sure everything is working as intended
  • If that is not the real problem, I can trace to the usage of where isSplitAction() is used in the regarded context and implement fix
  • If everything that uses isSplitAction() traced and still has the same issue, I may discuss some potential solutions with the core team if needed

This feature was already implemented a few weeks ago πŸ˜… And it will be closed soon

ZhenjaHorbach avatar Dec 25 '25 15:12 ZhenjaHorbach

Ah, I see. No worries. Probably I have to ask if the issue is already implemented next time, as I have no clue except a few, but those still need clarification 😁

Corfliss avatar Dec 25 '25 15:12 Corfliss

πŸ“£ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? πŸ’Έ

melvin-bot[bot] avatar Dec 31 '25 16:12 melvin-bot[bot]

@eh2077 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

melvin-bot[bot] avatar Jan 01 '26 23:01 melvin-bot[bot]