App icon indicating copy to clipboard operation
App copied to clipboard

LHN on HybridApp shows chats as Hidden and on web just empty spaces between the commas

Open m-natarajan opened this issue 11 months ago • 3 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: Reproducible in staging?: Needs Reproduction Reproducible in production?: Needs Reproduction If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @davidcardoza Slack conversation (hyperlinked to channel name): expensify_quality

Action Performed:

  1. Signout/Signin on HybridApp
  2. Navigate to the left-hand navigation (LHN) panel.

Expected Result:

Chats showing the email of the user

Actual Result:

On Hybrid app shows chat as Hidded On web just empty spaces between the commas

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • [ ] Android: Standalone
  • [ ] Android: HybridApp
  • [ ] Android: mWeb Chrome
  • [ ] iOS: Standalone
  • [x] iOS: HybridApp
  • [ ] iOS: mWeb Safari
  • [x] MacOS: Chrome / Safari
  • [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

m-natarajan avatar Dec 10 '24 22:12 m-natarajan

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

MelvinBot avatar Dec 10 '24 22:12 MelvinBot

Triggered auto assignment to @MarioExpensify (AutoAssignerNewDotQuality)

melvin-bot[bot] avatar Dec 10 '24 22:12 melvin-bot[bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] avatar Dec 10 '24 22:12 melvin-bot[bot]

Checking

MarioExpensify avatar Dec 12 '24 12:12 MarioExpensify

@twisterdotcom I had no luck reproducing this locally, do you mind giving it a try? Tested on Hybrid App for Android (Prod) and worked fine.

MarioExpensify avatar Dec 12 '24 17:12 MarioExpensify

@twisterdotcom, @MarioExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] avatar Dec 16 '24 09:12 melvin-bot[bot]

Requested QA team to check if they can reproduce it here

MarioExpensify avatar Dec 17 '24 11:12 MarioExpensify

We need to get the Onyx data for these reports in the thread please

muttmuure avatar Dec 17 '24 12:12 muttmuure

Doza should be able to right click one and copy Onyx data

muttmuure avatar Dec 17 '24 12:12 muttmuure

I agree, I can't recreate.

twisterdotcom avatar Dec 18 '24 00:12 twisterdotcom

Sorry for the delay, I was OOO yesterday. I can no longer reproduce. I will reopen the issue if/when it sprouts up again.

davidcardoza avatar Dec 18 '24 01:12 davidcardoza

Sorry to delete that, let's just err on the side of caution with posting the onyx state to GH. We redact sensitive information but I would rather we kept them in Slack just to be 100% safe

muttmuure avatar Dec 18 '24 23:12 muttmuure

@muttmuure - Sounds good, am I good to just link to the Slack convo in that case?

davidcardoza avatar Dec 19 '24 00:12 davidcardoza

Yeah Slack convo is great!

muttmuure avatar Dec 19 '24 00:12 muttmuure

Hey, thanks for the Onyx data, I'm wrapping up another issue and will come back to this soon. @muttmuure this is the first time I'll be working on Onyx related stuff, I'm may need some assistance 😅

MarioExpensify avatar Dec 23 '24 13:12 MarioExpensify

@davidcardoza @twisterdotcom @MarioExpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] avatar Dec 24 '24 09:12 melvin-bot[bot]

@davidcardoza, @twisterdotcom, @MarioExpensify Eep! 4 days overdue now. Issues have feelings too...

melvin-bot[bot] avatar Dec 24 '24 09:12 melvin-bot[bot]

@davidcardoza, @twisterdotcom, @MarioExpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

melvin-bot[bot] avatar Dec 26 '24 09:12 melvin-bot[bot]

Sorry for the late update, yesterday I worked on this one and I'm still trying to pinpoint where the "Hidden" was introduced in the pipeline. I'll bring updates today.

MarioExpensify avatar Dec 27 '24 11:12 MarioExpensify

@davidcardoza, @twisterdotcom, @MarioExpensify 10 days overdue. I'm getting more depressed than Marvin.

melvin-bot[bot] avatar Dec 30 '24 09:12 melvin-bot[bot]

I've left an update here, we've got an Onyx state export and it seems the personalDetailsList is missing a lot of data (that is the reason we're seeing the "Hidden" labels). I'm checking where we're sending the onyx updates that are possibly overwriting the valid values with empty. But so far it seems to be a backend issue.

MarioExpensify avatar Dec 30 '24 22:12 MarioExpensify

@davidcardoza, @twisterdotcom, @MarioExpensify 12 days overdue. Walking. Toward. The. Light...

melvin-bot[bot] avatar Jan 01 '25 09:01 melvin-bot[bot]

As discussed here, we're moving on removing the known user checks for expensify employees. PR is already drafted, I'll just wait on a confirmation before moving forward.

MarioExpensify avatar Jan 02 '25 14:01 MarioExpensify

@davidcardoza, @twisterdotcom, @MarioExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] avatar Jan 10 '25 09:01 melvin-bot[bot]

From @zsgreenwald comment here the bug may have happened again after we deployed the fix. I'll leave this issue open for another week so we can observe.

MarioExpensify avatar Jan 10 '25 12:01 MarioExpensify

@davidcardoza, @twisterdotcom, @MarioExpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

melvin-bot[bot] avatar Jan 14 '25 09:01 melvin-bot[bot]

@davidcardoza, @twisterdotcom, @MarioExpensify 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

melvin-bot[bot] avatar Jan 16 '25 09:01 melvin-bot[bot]

Okay, haven't received any more comments on this. Will be closing it, we can reopen if it surfaces back.

MarioExpensify avatar Jan 16 '25 11:01 MarioExpensify

I think we are experiencing the same issue again here https://expensify.enterprise.slack.com/archives/C05LX9D6E07/p1736985872463399

davidcardoza avatar Jan 16 '25 13:01 davidcardoza