App icon indicating copy to clipboard operation
App copied to clipboard

[$250] Workspace - Workspace created on OD doesn't get reflected on ND automatically

Open vincdargento opened this issue 1 year ago • 3 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.73-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): [email protected] Issue reported by: Applause Internal Team

Action Performed:

  1. Navigate to staging.new.expensify.com
  2. Sign in with the same account on both ND and OD
  3. Create a workspace on OD

Expected Result:

The workspace created on OD gets reflected on ND immediately

Actual Result:

The workspace created on OD doesn't get reflected on ND unless user manually refreshes the page

Workaround:

Unknown

Platforms:

  • [x] Android: Standalone
  • [x] Android: HybridApp
  • [x] Android: mWeb Chrome
  • [x] iOS: Standalone
  • [x] iOS: HybridApp
  • [x] iOS: mWeb Safari
  • [x] MacOS: Chrome / Safari
  • [ ] MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/8cc7000c-4cfd-4db7-86ab-df25ab90ba2d

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021866648105470425541
  • Upwork Job ID: 1866648105470425541
  • Last Price Increase: 2024-12-11
Issue OwnerCurrent Issue Owner: @dominictb

vincdargento avatar Dec 10 '24 14:12 vincdargento

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] avatar Dec 10 '24 14:12 melvin-bot[bot]

Job added to Upwork: https://www.upwork.com/jobs/~021866648105470425541

melvin-bot[bot] avatar Dec 11 '24 00:12 melvin-bot[bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dominictb (External)

melvin-bot[bot] avatar Dec 11 '24 00:12 melvin-bot[bot]

We're waiting for some proposals on this one.

stephanieelliott avatar Dec 13 '24 23:12 stephanieelliott

@stephanieelliott, @dominictb Eep! 4 days overdue now. Issues have feelings too...

melvin-bot[bot] avatar Dec 16 '24 09:12 melvin-bot[bot]

Hi, I'm Eugene from Callstack - expert contributor group. I’d like to work on this issue.

pasyukevich avatar Dec 16 '24 10:12 pasyukevich

Edited by proposal-police: This proposal was edited at 2024-12-16 14:22:43 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The list of workspaces in the new Expensify app does not update when a new workspace is created using the old Expensify app. This happens because the new app relies on Pusher events to update Onyx, but no Pusher event is fired when workspaces are created through the old app.

What is the root cause of that problem?

The old Expensify app uses a different API endpoint for creating workspaces. This endpoint does not trigger a Pusher event, which prevents the new app from receiving updates about the newly created workspace.

https://github.com/user-attachments/assets/09cbe445-5af7-4ebf-8fe1-6c536524d218

What changes do you think we should make in order to solve the problem?

  • Modify the backend to trigger Pusher events for workspace creation from the old Expensify. This would ensure real-time updates from the old Expensify to the new one.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

  • Tests would have to be on backend

What alternative solutions did you explore? (Optional)

  • Introduce a polling mechanism in the new app to periodically fetch the latest list of workspaces from the server.
  • Merge the fetched data into ONYXKEYS.COLLECTION.POLICY to ensure the workspace list in the UI stays up-to-date, even when no Pusher events are fired.

beodw avatar Dec 16 '24 14:12 beodw

@beodw Your proposal will be dismissed because you did not follow the proposal template.

github-actions[bot] avatar Dec 16 '24 14:12 github-actions[bot]

📣 @dominictb 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

melvin-bot[bot] avatar Dec 18 '24 02:12 melvin-bot[bot]

Great, thanks @pasyukevich! I've assigned you here.

stephanieelliott avatar Dec 18 '24 02:12 stephanieelliott

@pasyukevich, @stephanieelliott, @dominictb Huh... This is 4 days overdue. Who can take care of this?

melvin-bot[bot] avatar Dec 23 '24 09:12 melvin-bot[bot]

I am investigating the issue and will leave an update soon

pasyukevich avatar Dec 23 '24 13:12 pasyukevich

@pasyukevich @stephanieelliott @dominictb this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] avatar Dec 24 '24 09:12 melvin-bot[bot]

I've checked different scenarios with creating workspace (collect and control plans)

It is not reproducible anymore for me

pasyukevich avatar Dec 24 '24 13:12 pasyukevich

@pasyukevich, @stephanieelliott, @dominictb Still overdue 6 days?! Let's take care of this!

melvin-bot[bot] avatar Dec 25 '24 09:12 melvin-bot[bot]

@pasyukevich, @stephanieelliott, @dominictb 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

melvin-bot[bot] avatar Dec 27 '24 09:12 melvin-bot[bot]

@pasyukevich, @stephanieelliott, @dominictb 12 days overdue. Walking. Toward. The. Light...

melvin-bot[bot] avatar Dec 31 '24 09:12 melvin-bot[bot]

This issue has not been updated in over 14 days. @pasyukevich, @stephanieelliott, @dominictb eroding to Weekly issue.

melvin-bot[bot] avatar Jan 03 '25 09:01 melvin-bot[bot]

I can't repro it anymore either, let's close this

stephanieelliott avatar Jan 06 '25 23:01 stephanieelliott