App icon indicating copy to clipboard operation
App copied to clipboard

mWeb - Expense - Renamed the report system message is shown incorrectly.

Open IuliiaHerets opened this issue 1 year ago • 13 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: V9. 0.73-6 Reproducible in staging?: Yes Reproducible in production?: No If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: N Email or phone of affected tester (no customers): N Issue reported by: Applause Internal Team

Action Performed:

  1. Go to https://staging.new.expensify.com/home
  2. Open a workspace chat
  3. Create a expense
  4. Open the expense

Expected Result:

Renamed the report system message must not be shown.

Actual Result:

Renamed the report system message is shown incorrectly.

Workaround:

Unknown

Platforms:

  • [ ] Android: Standalone
  • [ ] Android: HybridApp
  • [x] Android: mWeb Chrome
  • [ ] iOS: Standalone
  • [ ] iOS: HybridApp
  • [ ] iOS: mWeb Safari
  • [ ] MacOS: Chrome / Safari
  • [ ] MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/b96ac34b-bf14-4b05-95db-8a309b479f38

View all open jobs on GitHub

IuliiaHerets avatar Dec 10 '24 09:12 IuliiaHerets

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] avatar Dec 10 '24 09:12 melvin-bot[bot]

Production

https://github.com/user-attachments/assets/5766d058-1ec8-4885-8da5-8e3bee848e68

IuliiaHerets avatar Dec 10 '24 09:12 IuliiaHerets

@IuliiaHerets is this an actual Deploy Blocker, or did you accidentally use the label?

jliexpensify avatar Dec 10 '24 09:12 jliexpensify

I can't repro on staging or prod v73-6 (Pixel 7) - closing:

Screenshot_20241210-204807

jliexpensify avatar Dec 10 '24 09:12 jliexpensify

@jliexpensify No, I added the label on purpose. Issue was reproduced in stg and prod with staging server off, issue was not repro with SS on. QA team can still repro this issue

https://github.com/user-attachments/assets/0b23eb7c-ab35-44c3-bead-0080938c7107

IuliiaHerets avatar Dec 10 '24 13:12 IuliiaHerets

Production @jliexpensify

https://github.com/user-attachments/assets/02c303a7-610f-472a-b316-c8698d46a1ac

IuliiaHerets avatar Dec 10 '24 13:12 IuliiaHerets

Clarifying if this is a true deploy blocker here

jliexpensify avatar Dec 10 '24 23:12 jliexpensify

Triggered auto assignment to @francoisl (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] avatar Dec 10 '24 23:12 melvin-bot[bot]

💬 A slack conversation has been started in #expensify-open-source

melvin-bot[bot] avatar Dec 10 '24 23:12 melvin-bot[bot]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

github-actions[bot] avatar Dec 10 '24 23:12 github-actions[bot]

Hi @francoisl - Applause seems to think this is a deploy blocker, but I don't think it is (and I can't repro). Puneet advised applying both labels here.

jliexpensify avatar Dec 10 '24 23:12 jliexpensify

I can repro on Web on staging, looking now. Not sure if it's a backend or NewDot blocker yet, let's keep both labels for now.

francoisl avatar Dec 11 '24 00:12 francoisl

This is a backend bug caused by https://github.com/Expensify/Web-Expensify/pull/44662/, removing the NewDot blocker label.

francoisl avatar Dec 11 '24 00:12 francoisl

I think the revert of https://github.com/Expensify/Web-Expensify/pull/44662 worked and we're good to remove the blocker label.

https://github.com/user-attachments/assets/da7db0e1-480d-451d-8cb4-b53a0fc97e2d

deetergp avatar Dec 11 '24 18:12 deetergp

Asked Applause for a retest here https://expensify.slack.com/archives/C9YU7BX5M/p1733940322271419?thread_ts=1733940210.713079&cid=C9YU7BX5M

deetergp avatar Dec 11 '24 18:12 deetergp

We cherry-picked a backend fix https://github.com/Expensify/Web-Expensify/pull/44733. Both Scott and I confirmed the regression is no longer on staging, removing the blocker label.

francoisl avatar Dec 11 '24 18:12 francoisl

Not reproducible https://github.com/user-attachments/assets/6abac4a3-59a5-4641-b3b5-017a2f02a20c

mvtglobally avatar Dec 12 '24 14:12 mvtglobally

Awesome, are we good to close this @francoisl @deetergp ?

jliexpensify avatar Dec 12 '24 23:12 jliexpensify

Looks that way @jliexpensify. Closing!

deetergp avatar Dec 13 '24 22:12 deetergp