App icon indicating copy to clipboard operation
App copied to clipboard
verified publisher icon Expensify

fix: Hmm it's not here in RHP is displayed after deleting a workspace

Open truph01 opened this issue 1 year ago • 2 comments

Explanation of Change

Fixed Issues

$ https://github.com/Expensify/App/issues/53659 PROPOSAL: https://github.com/Expensify/App/issues/53659#issuecomment-2522989204

Tests

  1. Go to ND.
  2. Login with the new Gmail account in incognito mode.
  3. Complete the onboarding.
  4. Click on "+" Fab Button and create a manual Expense with $1.
  5. Click on the "Next" button and click on "Just track it" and Track the expense.
  6. Click on Categorize it and click on the "Upgrade" button.
  7. Delete the workspace and click "Category it" again from the expense.
  8. Verify the RHP should show the modal to upgrade the plan so that it allows the creation of a ws automatically and chooses a category.
  • [x] Verify that no errors appear in the JS console

Offline tests

QA Steps

  • Same as tests

  • [x] Verify that no errors appear in the JS console

PR Author Checklist

  • [x] I linked the correct issue in the ### Fixed Issues section above
  • [x] I wrote clear testing steps that cover the changes made in this PR
    • [x] I added steps for local testing in the Tests section
    • [x] I added steps for the expected offline behavior in the Offline steps section
    • [x] I added steps for Staging and/or Production testing in the QA steps section
    • [x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • [x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • [x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • [x] I included screenshots or videos for tests on all platforms
  • [x] I ran the tests on all platforms & verified they passed on:
    • [x] Android: Native
    • [x] Android: mWeb Chrome
    • [x] iOS: Native
    • [x] iOS: mWeb Safari
    • [x] MacOS: Chrome / Safari
    • [x] MacOS: Desktop
  • [x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • [x] I followed proper code patterns (see Reviewing the code)
    • [x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • [x] I verified that comments were added to code that is not self explanatory
    • [x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • [x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • [x] If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • [x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • [x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • [x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • [x] I verified the JSDocs style guidelines (in STYLE.md) were followed
  • [x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • [x] I followed the guidelines as stated in the Review Guidelines
  • [x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • [x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • [x] I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • [x] I verified that if a function's arguments changed that all usages have also been updated correctly
  • [x] If any new file was added I verified that:
    • [x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • [x] If a new CSS style is added I verified that:
    • [x] A similar style doesn't already exist
    • [x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • [x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • [x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • [x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • [x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • [x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • [x] I verified that all the inputs inside a form are aligned with each other.
    • [x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • [x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • [x] I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • [x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/a2dac69a-bed4-4ef8-9820-28c7bfff61fd

Android: mWeb Chrome

https://github.com/user-attachments/assets/3e2269ee-9c32-459c-bd85-0b4b68c18039

iOS: Native

https://github.com/user-attachments/assets/bcc628ce-1d38-424e-bb32-1128d2f2e4f3

iOS: mWeb Safari

https://github.com/user-attachments/assets/b4ba06d7-8c0a-4e1f-8845-ea655fac4d0e

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/930130c1-0834-4e05-afb0-be185a206d1b

MacOS: Desktop

https://github.com/user-attachments/assets/c866e542-0eca-4317-8f0e-725a054c41fd

truph01 avatar Dec 10 '24 09:12 truph01

@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot[bot] avatar Dec 10 '24 09:12 melvin-bot[bot]

Reviewer Checklist

  • [x] I have verified the author checklist is complete (all boxes are checked off).
  • [x] I verified the correct issue is linked in the ### Fixed Issues section above
  • [x] I verified testing steps are clear and they cover the changes made in this PR
    • [x] I verified the steps for local testing are in the Tests section
    • [x] I verified the steps for Staging and/or Production testing are in the QA steps section
    • [x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • [x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • [x] I checked that screenshots or videos are included for tests on all platforms
  • [x] I included screenshots or videos for tests on all platforms
  • [x] I verified tests pass on all platforms & I tested again on:
    • [x] Android: Native
    • [x] Android: mWeb Chrome
    • [x] iOS: Native
    • [x] iOS: mWeb Safari
    • [x] MacOS: Chrome / Safari
    • [x] MacOS: Desktop
  • [x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • [x] I verified proper code patterns were followed (see Reviewing the code)
    • [x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • [x] I verified that comments were added to code that is not self explanatory
    • [x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • [x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • [x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • [x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • [x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • [x] I verified the JSDocs style guidelines (in STYLE.md) were followed
  • [x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • [x] I verified that this PR follows the guidelines as stated in the Review Guidelines
  • [x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • [x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • [x] I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • [x] If a new component is created I verified that:
    • [x] A similar component doesn't exist in the codebase
    • [x] All props are defined accurately and each prop has a /** comment above it */
    • [x] The file is named correctly
    • [x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • [x] The only data being stored in the state is data necessary for rendering and nothing else
    • [x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • [x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • [x] All JSX used for rendering exists in the render method
    • [x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • [x] If any new file was added I verified that:
    • [x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • [x] If a new CSS style is added I verified that:
    • [x] A similar style doesn't already exist
    • [x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • [x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • [x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • [x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • [x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • [x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • [x] I verified that all the inputs inside a form are aligned with each other.
    • [x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • [x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • [x] For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • [x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • [x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/5aabcc9f-7b07-48e3-82d4-f4de5d2ac921

Android: mWeb Chrome

https://github.com/user-attachments/assets/dafe8fec-0e3e-4f54-b8d2-93d0e2480451

iOS: Native

https://github.com/user-attachments/assets/3020de73-b980-445a-852d-31b37bee29f4

iOS: mWeb Safari

https://github.com/user-attachments/assets/d2f81afd-7290-4bca-885a-51795804d662

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/0b15d0e5-a50a-4cb1-a6c3-7448927ac2d0

MacOS: Desktop

https://github.com/user-attachments/assets/a14606d6-02c6-4159-a42e-3fbeb7b628db

jjcoffee avatar Dec 10 '24 09:12 jjcoffee

@jjcoffee PR is updated

truph01 avatar Dec 11 '24 20:12 truph01

A friendly bump on this one too @grgia :bow:

jjcoffee avatar Dec 16 '24 15:12 jjcoffee

@truph01 Can you resolve conflicts?

jjcoffee avatar Dec 18 '24 11:12 jjcoffee

bump on conflicts, thanks!

grgia avatar Dec 18 '24 15:12 grgia

@jjcoffee I just reverted all eslint fixes

truph01 avatar Jan 02 '25 21:01 truph01

🚧 @grgia has triggered a test build. You can view the workflow run here.

github-actions[bot] avatar Jan 03 '25 16:01 github-actions[bot]

:test_tube::test_tube: Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! :test_tube::test_tube:

Android :robot: iOS :apple:
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/53816/index.html ❌ FAILED ❌
Android The QR code can't be generated, because the iOS build failed
Desktop :computer: Web :spider_web:
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/53816/NewExpensify.dmg https://53816.pr-testing.expensify.com
Desktop Web

:eyes: View the workflow run that generated this build :eyes:

github-actions[bot] avatar Jan 03 '25 16:01 github-actions[bot]

Reviewing tomorrow!

jjcoffee avatar Jan 06 '25 11:01 jjcoffee

@truph01 Any ideas about the TS fail?

jjcoffee avatar Jan 07 '25 07:01 jjcoffee

@truph01 Also are you able to actually test this at the moment? For me on latest main I don't get any onboarding and I can't just track an expense (I think because there's no self-DM).

jjcoffee avatar Jan 07 '25 07:01 jjcoffee

are you able to actually test this at the moment

For now, when signing in with a new account, I cannot locate the self-DM to create the track expense. To test it, I need to use an older account that already has a self-DM report.

truph01 avatar Jan 07 '25 09:01 truph01

@truph01 You have conflicts.

jjcoffee avatar Jan 10 '25 16:01 jjcoffee

For me on latest main I don't get any onboarding and I can't just track an expense (I think because there's no self-DM).

@truph01 There have been some changes, which explains why this wasn't working. Can you update tweak the test steps? You need to choose Track and budget my expenses from the onboarding flow. Then when creating the expense you just select the self-DM (there is no longer a "just track it option" per this).

jjcoffee avatar Jan 10 '25 16:01 jjcoffee

@jjcoffee Looks like the issue is not reproducible in the latest main:

https://github.com/user-attachments/assets/61c7c63a-23a2-4c7a-b67d-3ed00766b0e6

Maybe PR has fixed it.

truph01 avatar Jan 10 '25 22:01 truph01

@truph01 Thanks for digging that up! I'm not sure what we'd normally do in this sort of situation, so I'm asking here.

jjcoffee avatar Jan 13 '25 10:01 jjcoffee

@truph01 Per this comment, can you merge main and then adjust your unit test to cover the other PR's changes? Sorry about the hassle!

jjcoffee avatar Jan 13 '25 14:01 jjcoffee

can you merge main and then adjust your unit test to cover the other PR's changes? Sorry about the hassle!

@jjcoffee Just to clarify, our PR only needs to handle the unit test and ignore changes to other files, correct? I'm asking because I noticed our PR also modifies the getActivePolicies function.

truph01 avatar Jan 13 '25 15:01 truph01

@truph01 Yes, basically we're now only adding unit tests for the changes in the other PR.

jjcoffee avatar Jan 13 '25 17:01 jjcoffee

@jjcoffee Test is updated

truph01 avatar Jan 14 '25 10:01 truph01

I just fixed conflicts

truph01 avatar Jan 17 '25 03:01 truph01

@grgia All yours! :pray:

jjcoffee avatar Jan 20 '25 09:01 jjcoffee

🚀 Deployed to staging by https://github.com/grgia in version: 9.0.89-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 success ✅
🍎🔄 iOS HybridApp 🍎🔄 success ✅

github-actions[bot] avatar Jan 23 '25 18:01 github-actions[bot]

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.89-8 🚀

platform result
🤖 android 🤖 true ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 success ✅

github-actions[bot] avatar Jan 28 '25 01:01 github-actions[bot]