Fix duplicate Concierge chats when NewDot accounts are merged

[blimpich]

Problem

1. create two accounts on staging.new.expensify.com (will need to have access to emails)
2. on account A, switch to Expensify Classic
3. go to Settings > Account > Merge Accounts
4. enter in the login for account B, use the validation code emailed to you, and merge the accounts together
5. switch back to New Expensify on account A

Expected result: Merge would be completed successfully.

Actual Result: There are two chats with Concierge

Why is this important?

Users are transitioning to NewDot and will soon begin to use the merge account feature on New Dot (in development here). This makes us look bad and is also really confusing to the user.

Solution

Figure out why we're keeping both Concierge chats in the the account merge process and fix it so that we're only returning one.

PS: Marking this as a #convert issue since it directly impacts the user experience of the Private Domain Onboarding Check project, which is a #convert initiative.

[melvin-bot[bot]]

Current assignee @sakluger is eligible for the Bug assigner, not assigning anyone new.

[sakluger]

Hey @blimpich - Thanks for moving the issue over to /App! Quick question - do you plan on working on this one? If so, could you please assign yourself too?

[blimpich]

I don't plan on working on this one right now. Will keep on my radar if my plate clears up 👍

[sakluger]

Okay, in that case, I'm going to switch to Weekly since it doesn't seem like a particularly high priority item.

[melvin-bot[bot]]

@sakluger this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot[bot]]

This issue has not been updated in over 15 days. @sakluger eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[sakluger]

No updates, waiting for a volunteer.

[sakluger]

Still no updates. I'll post to the Convert room this week to check on priority.

[sakluger]

Asked for volunteers in https://expensify.slack.com/archives/C07HPDRELLD/p1738168182051229.

[blimpich]

Picking up

[blimpich]

Update

Started work on this today. Started by writing a unit test to test the behavior. Draft PR up. Test is currently failing as expected. Will figure out a way to make it pass next.

[blimpich]

Update

Got a fix working that makes the test pass. Tested it locally as well and it works except there is some weirdness with the note that appears on the chat. It doesn't seem to be getting the correct user names for the note. I debugged it in App and seems like right here we're trying to get the accountIDs of the users but for some reason they accountIDs are undefined. Trying to figure that out.

[blimpich]

Okay I'm happy with this. One of the names is still Hidden but that kind of makes sense since that account technically doesn't exist anymore. Gonna put up for review.

[melvin-bot[bot]]

This issue has not been updated in over 15 days. @sakluger, @blimpich eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[blimpich]

This is fixed, for some reason the automation didn't close it.