App icon indicating copy to clipboard operation
App copied to clipboard

The approver sees a GBR on the workspace chat but no green button or dot in the reports - just a grey "submit" button

Open m-natarajan opened this issue 1 year ago • 5 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: Reproducible in staging?: Needs Reproduction Reproducible in production?: Needs Reproduction If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @flaviadefaria Slack conversation (hyperlinked to channel name): #migrate

Action Performed:

Prerequisite: Delay submission enabled for a workspace

  1. As employee submit an expense to the approver
  2. Login as approver and open the report

Expected Result:

No GBR for the approver if the report is in open status

Actual Result:

The approver sees a GBR on the workspace chat but no green button or dot in the reports - just a grey "submit" button

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • [ ] Android: Standalone
  • [ ] Android: HybridApp
  • [ ] Android: mWeb Chrome
  • [ ] iOS: Standalone
  • [ ] iOS: HybridApp
  • [ ] iOS: mWeb Safari
  • [x] MacOS: Chrome / Safari
  • [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

image (5)

View all open jobs on GitHub

m-natarajan avatar Dec 10 '24 00:12 m-natarajan

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] avatar Dec 10 '24 00:12 melvin-bot[bot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

MelvinBot avatar Dec 10 '24 00:12 MelvinBot

Can't reproduce this either, checked in via Slack to see if I need anything extra to reproduce this.

kadiealexander avatar Dec 10 '24 06:12 kadiealexander

These are the steps:

Prerequisite: Delay submission enabled for a workspace 1- As an employee create an expense directly in the workspace but don't submit it 2- Login as the approver/admin in NewDot

The expected behavior is to have no GBR and a grey submit button, but what I got was a GBR with the grey submit button.

flaviadefaria avatar Dec 10 '24 12:12 flaviadefaria

I just re-tested this and was able to recreate it so update the testing steps I had added above.

This is what the submitter sees (expected): image

This is what the admin sees (there shouldn't be a GBR): image

flaviadefaria avatar Dec 10 '24 21:12 flaviadefaria

Reproduced:

image

kadiealexander avatar Dec 11 '24 04:12 kadiealexander

Job added to Upwork: https://www.upwork.com/jobs/~021866704380239433141

melvin-bot[bot] avatar Dec 11 '24 04:12 melvin-bot[bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

melvin-bot[bot] avatar Dec 11 '24 04:12 melvin-bot[bot]

Hi! I'm Bartek from Callstack - expert contributor group. I’d like to work on this issue.

burczu avatar Dec 12 '24 11:12 burczu

@kadiealexander @mollfpr bump

burczu avatar Dec 16 '24 09:12 burczu

Also, I haven't been able to reproduce it:

https://github.com/user-attachments/assets/aa055a08-3a7d-4dce-b1bd-fa821a8ce858

I don't see the GBR, but the submit button is grey both sides - not sure if this is expected behaviour?

burczu avatar Dec 16 '24 09:12 burczu

Sorry for the delay 🙏 I'm still unable to reproduce the issue too.

Screenshot 2024-12-16 at 16 40 27

mollfpr avatar Dec 16 '24 09:12 mollfpr

@mollfpr, @kadiealexander Huh... This is 4 days overdue. Who can take care of this?

melvin-bot[bot] avatar Dec 16 '24 09:12 melvin-bot[bot]

I'm testing this again today.

flaviadefaria avatar Dec 17 '24 15:12 flaviadefaria

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] avatar Dec 18 '24 16:12 melvin-bot[bot]

@mollfpr, @kadiealexander Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] avatar Dec 20 '24 09:12 melvin-bot[bot]

Issue not reproducible during KI retests. (First week)

mvtglobally avatar Dec 21 '24 02:12 mvtglobally

@mollfpr @kadiealexander this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] avatar Dec 24 '24 09:12 melvin-bot[bot]

@mollfpr, @kadiealexander Still overdue 6 days?! Let's take care of this!

melvin-bot[bot] avatar Dec 24 '24 09:12 melvin-bot[bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] avatar Dec 25 '24 16:12 melvin-bot[bot]

@mollfpr, @kadiealexander 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

melvin-bot[bot] avatar Dec 26 '24 09:12 melvin-bot[bot]

Issue not reproducible during KI retests. (Second week)

mvtglobally avatar Dec 30 '24 04:12 mvtglobally

@mollfpr, @kadiealexander 12 days overdue. Walking. Toward. The. Light...

melvin-bot[bot] avatar Dec 30 '24 09:12 melvin-bot[bot]

I can't reproduce the issue. @kadiealexander We might be can close the issue.

mollfpr avatar Dec 30 '24 11:12 mollfpr

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] avatar Jan 01 '25 16:01 melvin-bot[bot]

Not overdue, just waiting to get confirmation to close this.

mollfpr avatar Jan 02 '25 16:01 mollfpr

We had some issues before the holidays so we're still waiting for all #migrate things to be deployed so that I can re-test everything -- including this.

flaviadefaria avatar Jan 03 '25 20:01 flaviadefaria

@mollfpr, @kadiealexander Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] avatar Jan 06 '25 09:01 melvin-bot[bot]

@mollfpr @kadiealexander this issue is now 4 weeks old, please consider:

  • Finding a contributor to fix the bug
  • Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
  • If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

melvin-bot[bot] avatar Jan 07 '25 09:01 melvin-bot[bot]

I ran into a similar version of this where there is a GBR and an approve button but the button isn't green. Though I think this might be because of the RBRs so let's just close this for now.

image

flaviadefaria avatar Jan 07 '25 19:01 flaviadefaria