App icon indicating copy to clipboard operation
App copied to clipboard
verified publisher icon Expensify

Deploy Checklist: New Expensify 2024-12-09

Open github-actions[bot] opened this issue 1 year ago • 6 comments

Release Version: 9.0.73-6 Compare Changes: https://github.com/Expensify/App/compare/production...staging

This release contains changes from the following pull requests:

  • [x] https://github.com/Expensify/App/pull/50118
  • [x] https://github.com/Expensify/App/pull/50559
  • [x] https://github.com/Expensify/App/pull/52059
  • [ ] https://github.com/Expensify/App/pull/52103
  • [ ] https://github.com/Expensify/App/pull/52164
  • [ ] https://github.com/Expensify/App/pull/52938
  • [ ] https://github.com/Expensify/App/pull/53076
  • [ ] https://github.com/Expensify/App/pull/53108
  • [ ] https://github.com/Expensify/App/pull/53198
  • [ ] https://github.com/Expensify/App/pull/53203
  • [x] https://github.com/Expensify/App/pull/53225
  • [ ] https://github.com/Expensify/App/pull/53246
  • [ ] https://github.com/Expensify/App/pull/53300
  • [ ] https://github.com/Expensify/App/pull/53321
  • [ ] https://github.com/Expensify/App/pull/53331
  • [x] https://github.com/Expensify/App/pull/53369
  • [x] https://github.com/Expensify/App/pull/53438
  • [ ] https://github.com/Expensify/App/pull/53449
  • [x] https://github.com/Expensify/App/pull/53462
  • [ ] https://github.com/Expensify/App/pull/53475
  • [x] https://github.com/Expensify/App/pull/53553
  • [x] https://github.com/Expensify/App/pull/53554
  • [x] https://github.com/Expensify/App/pull/53555
  • [x] https://github.com/Expensify/App/pull/53566
  • [x] https://github.com/Expensify/App/pull/53567
  • [x] https://github.com/Expensify/App/pull/53568
  • [ ] https://github.com/Expensify/App/pull/53576
  • [x] https://github.com/Expensify/App/pull/53610
  • [x] https://github.com/Expensify/App/pull/53615
  • [x] https://github.com/Expensify/App/pull/53616
  • [x] https://github.com/Expensify/App/pull/53632
  • [x] https://github.com/Expensify/App/pull/53634
  • [x] https://github.com/Expensify/App/pull/53635
  • [x] https://github.com/Expensify/App/pull/53636
  • [x] https://github.com/Expensify/App/pull/53646
  • [x] https://github.com/Expensify/App/pull/53648
  • [x] https://github.com/Expensify/App/pull/53652
  • [x] https://github.com/Expensify/App/pull/53667
  • [x] https://github.com/Expensify/App/pull/53678
  • [x] https://github.com/Expensify/App/pull/53704
  • [x] https://github.com/Expensify/App/pull/53710
  • [x] https://github.com/Expensify/App/pull/53720
  • [ ] https://github.com/Expensify/App/pull/53721
  • [x] https://github.com/Expensify/App/pull/53742
  • [x] https://github.com/Expensify/App/pull/53774
  • [x] https://github.com/Expensify/App/pull/53784
  • [x] https://github.com/Expensify/App/pull/53786
  • [x] https://github.com/Expensify/App/pull/53787

Deploy Blockers:

  • [x] https://github.com/Expensify/App/issues/53765
  • [x] https://github.com/Expensify/App/issues/53766
  • [x] https://github.com/Expensify/App/issues/53767
  • [x] https://github.com/Expensify/App/issues/53768
  • [x] https://github.com/Expensify/App/issues/53769
  • [x] https://github.com/Expensify/App/issues/53770
  • [x] https://github.com/Expensify/App/issues/53771
  • [x] https://github.com/Expensify/App/issues/53772
  • [x] https://github.com/Expensify/App/issues/53777
  • [x] https://github.com/Expensify/App/issues/53780
  • [x] https://github.com/Expensify/App/issues/53783
  • [x] https://github.com/Expensify/App/issues/53793
  • [ ] https://github.com/Expensify/App/issues/53819
  • [x] https://github.com/Expensify/App/issues/53822
  • [x] https://github.com/Expensify/App/issues/53823
  • [ ] https://github.com/Expensify/App/issues/53833
  • [ ] https://github.com/Expensify/App/issues/53848

Deployer verifications:

  • [ ] I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • [ ] I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • [ ] I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

github-actions[bot] avatar Dec 09 '24 15:12 github-actions[bot]

Demoting https://github.com/Expensify/App/issues/53768 (UI issue)

MarioExpensify avatar Dec 09 '24 19:12 MarioExpensify

Demoted #53772

amyevans avatar Dec 09 '24 19:12 amyevans

Demoted https://github.com/Expensify/App/issues/53783

tgolen avatar Dec 09 '24 20:12 tgolen

Regression is at 80% completed

No Blockers, team is working on TC and PRs

mvtglobally avatar Dec 10 '24 03:12 mvtglobally

Regression is at 9% left.

PRs: https://github.com/Expensify/App/pull/52103 - Pending validation on Android and iOS https://github.com/Expensify/App/pull/52164 - Pending validation on Android https://github.com/Expensify/App/pull/52938 - failing with https://github.com/Expensify/App/pull/52938#issuecomment-2529153433. repro in Prod checking off https://github.com/Expensify/App/pull/53076 - Pending validation on iOS https://github.com/Expensify/App/pull/53108 - Found KI https://github.com/Expensify/App/pull/53108#issuecomment-2531026088 https://github.com/Expensify/App/pull/53198 - found KI https://github.com/Expensify/App/pull/53198#issuecomment-2531036138 Pending on iOS https://github.com/Expensify/App/pull/53203 - KI only on Web https://github.com/Expensify/App/pull/53203#issuecomment-2531044817

DB: https://github.com/Expensify/App/issues/53819 https://github.com/Expensify/App/issues/53822 https://github.com/Expensify/App/issues/53823

izarutskaya avatar Dec 10 '24 09:12 izarutskaya

Demoting https://github.com/Expensify/App/issues/53822 --> minor UI issue

cristipaval avatar Dec 10 '24 11:12 cristipaval

@mvtglobally @izarutskaya what's the status of regression?

luacmartins avatar Dec 10 '24 18:12 luacmartins

@luacmartins Wrapping last 1%

mvtglobally avatar Dec 10 '24 18:12 mvtglobally

Regression is completed. Checking last CP

mvtglobally avatar Dec 10 '24 20:12 mvtglobally

@mvtglobally I see that the PRs below are still unchecked, are we still waiting on validation for them?

  • https://github.com/Expensify/App/pull/52103
  • https://github.com/Expensify/App/pull/53331

luacmartins avatar Dec 10 '24 20:12 luacmartins

Unchecked PRs https://github.com/Expensify/App/pull/52103 - is failing with KI https://github.com/Expensify/App/issues/50796, https://github.com/Expensify/App/issues/53833, and https://github.com/Expensify/App/issues/53812 https://github.com/Expensify/App/pull/53331 - Native app. KI: bug where the auth token is always empty(searching KI ID) . We are blocked on Android, but rest are pass

mvtglobally avatar Dec 10 '24 20:12 mvtglobally

Thanks! Let me know when you're done and I'll kick off the deploy if nothing else shows up.

luacmartins avatar Dec 10 '24 20:12 luacmartins

@mvtglobally are there any pending tasks on your end?

luacmartins avatar Dec 10 '24 21:12 luacmartins

No pending QA tasks. You need to check those 2 PRs if they are good to go.

mvtglobally avatar Dec 10 '24 22:12 mvtglobally

Nice! In that case we're good to ship.

luacmartins avatar Dec 10 '24 22:12 luacmartins

:shipit:

luacmartins avatar Dec 10 '24 22:12 luacmartins