Expensify
[$250] Implement animation to the switch expandable sections
This is a request from @dubielzyk-expensify to add animation to the expanding section in Workflows (and other similar places in the app) where after toggling the switch, we open the section like this https://github.com/user-attachments/assets/43e48c18-6b18-4ec6-bc7f-3238f125d616
cc @sumo-slonik @blazejkustra would like to implement this - can you please comment
@dubielzyk-expensify do you have some specifics about the easing/ animation at this moment?
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021866452926963427651
- Upwork Job ID: 1866452926963427651
- Last Price Increase: 2024-12-10
Issue Owner
Current Issue Owner: @sumo-slonik
Current assignee @dubielzyk-expensify is eligible for the Design assigner, not assigning anyone new.
![melvin-bot[bot] avatar](https://avatars.githubusercontent.com/in/179547?v=4 "Published by a pub.dev verified publisher"){kind=small}
Triggered auto assignment to @stephanieelliott (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.
@dubielzyk-expensify do you have some specifics about the easing/ animation at this moment?
Let's start with an ease-out and see how that feels. Excited about this :)
Hi, I am very eager to get started on this :) I have an idea how to do it using reanimated and I'm already on it
Job added to Upwork: https://www.upwork.com/jobs/~021866452926963427651
Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)
Is already working, I am checking where in other places of the application could be used such acordition element with switch
https://github.com/user-attachments/assets/e140f142-05cb-4ca0-8739-50b71bd966c0
https://github.com/user-attachments/assets/b335ce22-d00b-46f6-bb2d-0d96379039af
It is already working everywhere the last place with a problem is the accounting tab, there I have a problem when importing because the component changes before the widget collapses and this causes the illusion of not smooth animation, I have to change the logic of state management in this place, but we are getting closer :D
https://github.com/user-attachments/assets/7002a31e-5547-4376-8b52-696c1aad4ff7
while working on animations in imoprt I found such a bug on main branch, I wanted to fix it within this task but it is more work than what is related to animations so I think it deserves a separate issiue:
https://github.com/user-attachments/assets/7a78fbec-ca59-4ffa-9b7f-747fdc88d029
All switch animations completed:
https://github.com/user-attachments/assets/01a96de6-9e03-4e23-994f-c6cbcd195e0e
@mountiny What do we want to do about this bug? https://github.com/Expensify/App/issues/53759#issuecomment-2538865532
@sumo-slonik I dont think we ahve to worry about this, its a replay effect issue no need to spend time on it
Also draft PR already has recordings from all platforms: https://github.com/Expensify/App/pull/53938
@thesahindia I think you can have a look at the code and start reviewing 😄 Let us know if you have any questions
This issue has not been updated in over 15 days. @stephanieelliott, @mountiny, @sumo-slonik, @thesahindia, @dubielzyk-expensify eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
⚠️ Looks like this issue was linked to a Deploy Blocker here
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
Reviewing label has been removed, please complete the "BugZero Checklist".
The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.87-3 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:
- https://github.com/Expensify/App/pull/53938
If no regressions arise, payment will be issued on 2025-01-28. :confetti_ball:
For reference, here are some details about the assignees on this issue:
- @sumo-slonik does not require payment (Contractor)
- @thesahindia requires payment through NewDot Manual Requests
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [ ] [@thesahindia] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
- [ ] [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
Payment Summary
- Contributor: @sumo-slonik is from an agency-contributor and not due payment
- Reviewer: @thesahindia owed $250 via NewDot
BugZero Checklist (@stephanieelliott)
- [ ] I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
- [ ] I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1866452926963427651/hired)
- [ ] I have paid out the Upwork contracts or cancelled the ones that are incorrect
- [ ] I have verified the payment summary above is correct
We are continuing to wait here for the tick under the new PR after the reverting of the previous one, so we should not mark it as ready yet.